Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(Cardinal): redefine toNat and toPartENat #10472

Closed
wants to merge 24 commits into from
Closed

[Merged by Bors] - refactor(Cardinal): redefine toNat and toPartENat #10472

wants to merge 24 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 13, 2024 •
edited

@urkud urkud added the t-logic Logic (model theory, set theory, etc) label Feb 13, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Feb 13, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 13, 2024
urkud added a commit that referenced this pull request Feb 13, 2024
@urkud
feat(ENat): add several lemmas
bf36416 
Add lemmas needed for #10472
@urkud urkud mentioned this pull request Feb 13, 2024
Closed
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 13, 2024
@urkud urkud mentioned this pull request Feb 14, 2024
Open
8 tasks
mathlib-bors bot pushed a commit that referenced this pull request Feb 14, 2024
@urkud
feat(ENat): add several lemmas (#10508)
5cc14ef 
Add lemmas needed for #10472
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 14, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 15, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Feb 15, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Feb 15, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@urkud urkud added the awaiting-review The author would like community review of the PR label Feb 15, 2024
jcommelin
jcommelin approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 15, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 15, 2024
@urkud
refactor(Cardinal): redefine toNat and toPartENat (#10472)
ce62855 
Redefine these operations in terms of `toENat`.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 15, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 15, 2024
@urkud
refactor(Cardinal): redefine toNat and toPartENat (#10472)
6af8f3b 
Redefine these operations in terms of `toENat`.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Cardinal): redefine toNat and toPartENat [Merged by Bors] - refactor(Cardinal): redefine toNat and toPartENat Feb 16, 2024
@mathlib-bors mathlib-bors bot closed this Feb 16, 2024
@mathlib-bors mathlib-bors bot deleted the YK-toNat-def branch February 16, 2024 00:13
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
@urkud @riccardobrasca
feat(ENat): add several lemmas (#10508)
6d1c504 
Add lemmas needed for #10472
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
@urkud @riccardobrasca
refactor(Cardinal): redefine toNat and toPartENat (#10472)
3be6a79 
Redefine these operations in terms of `toENat`.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@urkud @dagurtomas
feat(ENat): add several lemmas (#10508)
85c7f86 
Add lemmas needed for #10472
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@urkud @dagurtomas
refactor(Cardinal): redefine toNat and toPartENat (#10472)
ea8090b 
Redefine these operations in terms of `toENat`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, set theory, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @leanprover-community-mathlib4-bot @jcommelin