[Merged by Bors] - refactor: drop some *HomClasses
#10544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop classes that mix `OrderHomClass` with algebraic hom classes.
j-loreaux
reviewed
Feb 14, 2024
| @[to_additive (attr := coe) | ||
| "Turn an element of a type `F` satisfying `OrderAddMonoidHomClass F α β` into an actual | ||
| `OrderAddMonoidHom`. This is declared as the default coercion from `F` to `α →+o β`."] | ||
| def OrderMonoidHomClass.toOrderMonoidHom [OrderMonoidHomClass F α β] (f : F) : α →*o β := | ||
| { (f : α →* β) with monotone' := monotone f } | ||
| def OrderMonoidHomClass.toOrderMonoidHom [OrderHomClass F α β] [MonoidHomClass F α β] (f : F) : |
There was a problem hiding this comment.
It's a bit weird to put this in the OrderMonoidHomClass namespace given that such a class doesn't exist anymore, but I don't have a better suggestion.
There was a problem hiding this comment.
How about
Suggested change
| def OrderMonoidHomClass.toOrderMonoidHom [OrderHomClass F α β] [MonoidHomClass F α β] (f : F) : | |
| def FunLike.toOrderMonoidHom [OrderHomClass F α β] [MonoidHomClass F α β] (f : F) : |
There was a problem hiding this comment.
Let me do it for all bundled homs at once.
j-loreaux
reviewed
Feb 14, 2024
j-loreaux
added
awaiting-author
urkud
added
awaiting-review
4 tasks
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
bors merge |
|
Build failed (retrying...): |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
*HomClasses*HomClasses
riccardobrasca
pushed a commit
that referenced
this pull request
Feb 18, 2024
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop classes that mix
OrderHomClasswith algebraic hom classes.