New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat port Data.Nat.Pow #1050
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardobrasca
added
WIP
Work in progress
mathlib-port
This is a port of a theory file from mathlib.
labels
Dec 15, 2022
4 tasks
riccardobrasca
added
blocked-by-other-PR
This PR depends on another PR which is still in the queue.
awaiting-review
The author would like community review of the PR
and removed
WIP
Work in progress
labels
Dec 15, 2022
semorrison
removed
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue.
label
Dec 15, 2022
2 tasks
(No need to include git shas in the PR description anymore.) |
semorrison
reviewed
Dec 16, 2022
Mathlib/Data/Nat/Pow.lean
Outdated
Comment on lines
24
to
31
#print Nat.pow_le_pow_of_le_left /- | ||
-- This is redundant with `pow_le_pow_of_le_left'`, | ||
-- We leave a version in the `nat` namespace as well. | ||
-- (The global `pow_le_pow_of_le_left` needs an extra hypothesis `0 ≤ x`.) | ||
protected theorem pow_le_pow_of_le_left {x y : ℕ} (H : x ≤ y) : ∀ i : ℕ, x ^ i ≤ y ^ i := | ||
pow_le_pow_of_le_left' H | ||
#align nat.pow_le_pow_of_le_left Nat.pow_le_pow_of_le_left | ||
-/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be replaced with just the #align
statement. (The lemmas has moved to Std
.)
bors merge |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Dec 16, 2022
bors bot
pushed a commit
that referenced
this pull request
Dec 16, 2022
aba57d4d3dae35460225919dcd82fe91355162f9 - [x] depends on #1043 Co-authored-by: Siddhartha Gadgil <siddhartha.gadgil@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
feat port Data.Nat.Pow
[Merged by Bors] - feat port Data.Nat.Pow
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mathlib-port
This is a port of a theory file from mathlib.
ready-to-merge
This PR has been sent to bors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aba57d4d3dae35460225919dcd82fe91355162f9