New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: port Algebra.GroupPower.Order #1043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddhartha-gadgil
changed the title
WIP port Algebra.GroupPower.Order
feat: port Algebra.GroupPower.Order
Dec 15, 2022
siddhartha-gadgil
added
mathlib-port
This is a port of a theory file from mathlib.
awaiting-review
The author would like community review of the PR
labels
Dec 15, 2022
This was referenced Dec 15, 2022
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Ruben-VandeVelde
approved these changes
Dec 15, 2022
semorrison
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Dec 15, 2022
2 tasks
Please add a comment with the phrase "Porting note", e.g. "-- Porting note: mono not implemented yet", in the source code, so we can identify these afterwards. |
semorrison
force-pushed
the
algebra_grouppower_order
branch
from
December 15, 2022 21:53
fcd03f1
to
d6c3a71
Compare
bors merge |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Dec 15, 2022
bors bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
from fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e have commented out `mono` annotations as the corresponding tactic is not yet implemented. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
feat: port Algebra.GroupPower.Order
[Merged by Bors] - feat: port Algebra.GroupPower.Order
Dec 15, 2022
bors bot
pushed a commit
that referenced
this pull request
Dec 16, 2022
aba57d4d3dae35460225919dcd82fe91355162f9 - [x] depends on #1043 Co-authored-by: Siddhartha Gadgil <siddhartha.gadgil@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mathlib-port
This is a port of a theory file from mathlib.
ready-to-merge
This PR has been sent to bors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e
have commented out
mono
annotations as the corresponding tactic is not yet implemented.