-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: More big operator lemmas #10551
Closed
Closed
Changes from 23 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
203e465
feat: More big operator lemmas
YaelDillies 2ac4370
Update Mathlib/Algebra/BigOperators/Basic.lean
YaelDillies af812f7
Update Mathlib/Algebra/BigOperators/Pi.lean
YaelDillies 479cec9
Update Mathlib/Algebra/BigOperators/Pi.lean
YaelDillies 2c75941
`Pi.mulSingle` lemmas
YaelDillies 3eaeafb
nolint
YaelDillies d5ef523
explain simpNF false positive
YaelDillies 88bbd97
extra lemma
YaelDillies 56cde85
fix Algebra.Module.BigOperators
YaelDillies 73ff1da
Merge remote-tracking branch 'origin/master' into prod_fiberwise_eq_p…
YaelDillies 13c38c8
see also
YaelDillies e066895
rewrap
YaelDillies 90b3a7b
Merge remote-tracking branch 'origin/master' into prod_fiberwise_eq_p…
YaelDillies 85551a4
extract a lemma
YaelDillies 347a01a
fix
YaelDillies 447f9e0
fix GroupTheory.PGroup
YaelDillies 69f27dd
Merge remote-tracking branch 'origin/master' into prod_fiberwise_eq_p…
YaelDillies dc3bc75
prod_subset
YaelDillies d5994a1
Merge remote-tracking branch 'origin/master' into prod_fiberwise_eq_p…
YaelDillies 4cea4a7
Eric's rw
YaelDillies ded7555
Merge remote-tracking branch 'origin/master' into prod_fiberwise_eq_p…
YaelDillies 5c55001
Merge remote-tracking branch 'origin/master' into prod_fiberwise_eq_p…
YaelDillies 3c2fe13
fix GroupTheory.PGroup
YaelDillies f650b66
Merge remote-tracking branch 'origin/master' into prod_fiberwise_eq_p…
YaelDillies 748d331
missing newline
YaelDillies dff0434
Merge remote-tracking branch 'origin/master' into prod_fiberwise_eq_p…
YaelDillies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to match
x ∉ s₁ → f x = 1
fromFinset.prod_subset
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's much more useful this way, I find, as it can be interpreted as saying that the support of
f
is a subset ofs
.Finset.prod_subset
can't really afford to be stated like that as it instead wants to emphasizes₁ \ s₂
.