[Merged by Bors] - perf: improve to_additive performance #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors merge |
|
Canceled. |
|
bors merge |
|
Canceled. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 16, 2022
Using ``` def Ones : ℕ → Q(Nat) | 0 => q(1) | (n+1) => q($(Ones n) + $(Ones n)) ``` The new `to_additive` takes `45ms` on `Ones 500` (higher gives stack overflows) The old `to_additive` takes `13794ms` on `Ones 17` (exponential in the argument) There is still one issue workaround by using `transform` in `etaExpand`. * Remove `replaceRecM` and `replaceRecMeta` that are exponentially slow * Remove `replaceRecTraversal` because its interface is less convenient than `replaceRec` Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Build failed: |
|
@siddhartha-gadgil's #1043 resulted in import loops here, which I'm resolving by splitting |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 16, 2022
Using ``` def Ones : ℕ → Q(Nat) | 0 => q(1) | (n+1) => q($(Ones n) + $(Ones n)) ``` The new `to_additive` takes `45ms` on `Ones 500` (higher gives stack overflows) The old `to_additive` takes `13794ms` on `Ones 17` (exponential in the argument) There is still one issue workaround by using `transform` in `etaExpand`. * Remove `replaceRecM` and `replaceRecMeta` that are exponentially slow * Remove `replaceRecTraversal` because its interface is less convenient than `replaceRec` Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
The new
to_additivetakes45msonOnes 500(higher gives stack overflows)The old
to_additivetakes13794msonOnes 17(exponential in the argument)There is still one issue workaround by using
transforminetaExpand.replaceRecMandreplaceRecMetathat are exponentially slowreplaceRecTraversalbecause its interface is less convenient thanreplaceRecApparently this now fails because of
import Qq...