Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.Ring.Equiv #1077

Closed
wants to merge 18 commits into from
Closed

[Merged by Bors] - feat: port Algebra.Ring.Equiv #1077

wants to merge 18 commits into from

Conversation

ADedecker
Copy link
Member

@ADedecker ADedecker commented Dec 16, 2022 •
edited
Loading

@ADedecker ADedecker added WIP Work in progress help-wanted The author needs attention to resolve issues labels Dec 16, 2022
@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Dec 17, 2022
@ADedecker ADedecker added the blocked-by-other-PR This PR depends on another PR to Mathlib label Dec 21, 2022
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR to Mathlib label Dec 22, 2022
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 22, 2022
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 23, 2022
@ADedecker ADedecker removed the help-wanted The author needs attention to resolve issues label Dec 23, 2022
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 24, 2022
@ADedecker ADedecker removed the awaiting-author A reviewer has asked the author a question or requested changes label Dec 24, 2022
@ADedecker ADedecker added the awaiting-review The author would like community review of the PR label Dec 24, 2022
@ChrisHughes24 ChrisHughes24 added the mathlib-port This is a port of a theory file from mathlib. label Dec 26, 2022
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 26, 2022
bors bot pushed a commit that referenced this pull request Dec 26, 2022
@ADedecker @ChrisHughes24
feat: port Algebra.Ring.Equiv (#1077)
84ee4ca 
See discussion [here](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/norm_cast.3A.20badly.20shaped.20lemma) and [there](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Algebra.2ERing.2EEquiv.20help.20request)

I used #835 as a reference

- [x] depends on: #1150

Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented Dec 26, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.Ring.Equiv [Merged by Bors] - feat: port Algebra.Ring.Equiv Dec 26, 2022
@bors bors bot closed this Dec 26, 2022
@bors bors bot deleted the AD_PORT_RingEquiv branch December 26, 2022 15:11
@github-actions github-actions bot mentioned this pull request Dec 27, 2022
Closed
@eric-wieser eric-wieser mentioned this pull request Mar 21, 2023
Closed
bors bot pushed a commit that referenced this pull request Mar 21, 2023
@eric-wieser
fix: add incorrectly-deleted lemmas (#3008)
b0625e5 
These lemmas are still needed in Lean 4, despite claims in #1077 that they are not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ADedecker @semorrison @ChrisHughes24 @jcommelin