Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: better coercions from hom classes to hom types #1150

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat: better coercions from hom classes to hom types #1150

wants to merge 3 commits into from

Conversation

ADedecker
Copy link
Member

Discussed here

@ADedecker ADedecker mentioned this pull request Dec 21, 2022
Closed
1 task
@ADedecker ADedecker marked this pull request as ready for review December 21, 2022 17:51
@ADedecker ADedecker added the awaiting-review The author would like community review of the PR label Dec 21, 2022
jcommelin
jcommelin approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉
Approved by Mario

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 22, 2022
bors bot pushed a commit that referenced this pull request Dec 22, 2022
@ADedecker
feat: better coercions from hom classes to hom types (#1150)
e865530 
Discussed [here](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Algebra.2ERing.2EEquiv.20help.20request/near/317172807)
@bors
Copy link

bors bot commented Dec 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: better coercions from hom classes to hom types [Merged by Bors] - feat: better coercions from hom classes to hom types Dec 22, 2022
@bors bors bot closed this Dec 22, 2022
@bors bors bot deleted the AD_add_intermediate_coe_defs branch December 22, 2022 21:34
bors bot pushed a commit that referenced this pull request Dec 26, 2022
@ADedecker @ChrisHughes24
feat: port Algebra.Ring.Equiv (#1077)
84ee4ca 
See discussion [here](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/norm_cast.3A.20badly.20shaped.20lemma) and [there](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Algebra.2ERing.2EEquiv.20help.20request)

I used #835 as a reference

- [x] depends on: #1150

Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ADedecker @jcommelin @semorrison