Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(LinearAlgebra/DirectSum/Finsupp) : tensor products of finsupp functions #10824
feat(LinearAlgebra/DirectSum/Finsupp) : tensor products of finsupp functions #10824
Changes from 6 commits
d8e50fc
fa4cb7e
53ee15d
d55ac1e
2f1ebe7
c28b2e6
2320a61
1fdd0aa
d76a5a9
423a61d
2efdc69
98b197b
7f13321
aa3eaf6
3e12239
8458d4e
e259731
2e74096
19af3b0
d26f775
660e471
65e6c20
a7b0441
8af8487
4f65f96
b1742d9
85b2839
3fb1a0a
c375537
e296050
ef9a571
6c74740
d9ce8e2
ec42703
d7c43b0
32d9c2e
417d963
337b52a
5a5f1a9
cdc4ef9
5112ca4
47a6c00
746bb43
20c8b2d
1665702
f0a5d8b
fc8f0d1
0e751b9
d3ade35
87d6d87
cdfd7b1
91c0278
c2496b2
02e19a6
073c214
47be110
119763f
c16067f
845bb95
8004cfc
de94570
cfa238f
aa4b9a4
f3d3ee2
df63d70
8d31f5d
f1719b8
c724436
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 16 in Mathlib/LinearAlgebra/DirectSum/Finsupp.lean
GitHub Actions / Lint style
Check failure on line 16 in Mathlib/LinearAlgebra/DirectSum/Finsupp.lean
GitHub Actions / Lint style
Check failure on line 18 in Mathlib/LinearAlgebra/DirectSum/Finsupp.lean
GitHub Actions / Lint style
Check failure on line 18 in Mathlib/LinearAlgebra/DirectSum/Finsupp.lean
GitHub Actions / Lint style
Check failure on line 20 in Mathlib/LinearAlgebra/DirectSum/Finsupp.lean
GitHub Actions / Lint style
Check failure on line 20 in Mathlib/LinearAlgebra/DirectSum/Finsupp.lean
GitHub Actions / Lint style
Check failure on line 22 in Mathlib/LinearAlgebra/DirectSum/Finsupp.lean
GitHub Actions / Lint style
Check failure on line 22 in Mathlib/LinearAlgebra/DirectSum/Finsupp.lean
GitHub Actions / Lint style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arguably this should be called
TensorProduct.finsuppLeft
for consistency withTensorProduct.directSumLeft
andTensorProduct.prodLeft
, and similarly forRight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I had to check for the actual meaning of “Arguably” ! — it doesn't mean one can argue, and indeed, i won't…)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the initial file,
finsuppTensorProductFinsupp
is in the root name space. Is this reasonable? (but I don't want to have to track at all instances…)Check failure on line 179 in Mathlib/LinearAlgebra/DirectSum/Finsupp.lean
GitHub Actions / Lint style
Check failure on line 179 in Mathlib/LinearAlgebra/DirectSum/Finsupp.lean
GitHub Actions / Lint style
Check failure on line 187 in Mathlib/LinearAlgebra/DirectSum/Finsupp.lean
GitHub Actions / Lint style
Check failure on line 187 in Mathlib/LinearAlgebra/DirectSum/Finsupp.lean
GitHub Actions / Lint style
Check failure on line 62 in Mathlib/LinearAlgebra/TensorProduct/MvPolynomial.lean
GitHub Actions / Lint style
Check failure on line 62 in Mathlib/LinearAlgebra/TensorProduct/MvPolynomial.lean
GitHub Actions / Lint style
Check failure on line 74 in Mathlib/LinearAlgebra/TensorProduct/MvPolynomial.lean
GitHub Actions / Lint style
Check failure on line 74 in Mathlib/LinearAlgebra/TensorProduct/MvPolynomial.lean
GitHub Actions / Lint style