Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(CategoryTheory/Monoidal): redefine tensorLeft by using whiskering #10898

Closed
wants to merge 17 commits into from

Conversation

yuma-mizuno
Copy link
Collaborator

@yuma-mizuno yuma-mizuno commented Feb 23, 2024

@yuma-mizuno yuma-mizuno added the t-category-theory Category theory label Feb 23, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 23, 2024
@yuma-mizuno yuma-mizuno added the awaiting-review The author would like community review of the PR label Feb 24, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 27, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 27, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Feb 27, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 27, 2024
set_option linter.uppercaseLean3 false in
#align Bimod.comp_whisker_right_Bimod Bimod.comp_whisker_right_bimod
#align Bimod.comp_whisker_right_Bimod Bimod.comp_whiskerRight_bimod

theorem whisker_right_id_bimod {X Y : Mon_ C} {M N : Bimod X Y} (f : M ⟶ N) :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
theorem whisker_right_id_bimod {X Y : Mon_ C} {M N : Bimod X Y} (f : M ⟶ N) :
theorem whiskerRight_id_bimod {X Y : Mon_ C} {M N : Bimod X Y} (f : M ⟶ N) :

In this file, there are a few other whisker_left/right names which should be changed similarly.

@joelriou
Copy link
Collaborator

Apart from a few name changes, this looks good to me. Thanks!

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 28, 2024

✌️ yuma-mizuno can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 28, 2024
@yuma-mizuno
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 29, 2024
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 29, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory/Monoidal): redefine tensorLeft by using whiskering [Merged by Bors] - feat(CategoryTheory/Monoidal): redefine tensorLeft by using whiskering Feb 29, 2024
@mathlib-bors mathlib-bors bot closed this Feb 29, 2024
@mathlib-bors mathlib-bors bot deleted the ymizuno-tensorLeft branch February 29, 2024 02:34
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
utensil pushed a commit that referenced this pull request Mar 26, 2024
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants