Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: rename arguments to PiTensorProduct induction principles #10904

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Feb 24, 2024

This looks much nicer in the induction tactic than C1 and Cp, as

induction a using PiTensorProduct.induction_on with
| smul_tprod r a => sorry
| add x y hx hy => sorry

Open in Gitpod

This looks much nicer in the `induction` tactic than `C1` and `Cp`.
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Feb 24, 2024
@riccardobrasca
Copy link
Member

Thanks!

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 24, 2024

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 24, 2024
@eric-wieser
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 24, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 24, 2024
…0904)

This looks much nicer in the `induction` tactic than `C1` and `Cp`, as
```lean
induction a using PiTensorProduct.induction_on with
| smul_tprod r a => sorry
| add x y hx hy => sorry
```
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 24, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 24, 2024
…0904)

This looks much nicer in the `induction` tactic than `C1` and `Cp`, as
```lean
induction a using PiTensorProduct.induction_on with
| smul_tprod r a => sorry
| add x y hx hy => sorry
```
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 24, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: rename arguments to PiTensorProduct induction principles [Merged by Bors] - chore: rename arguments to PiTensorProduct induction principles Feb 24, 2024
@mathlib-bors mathlib-bors bot closed this Feb 24, 2024
@mathlib-bors mathlib-bors bot deleted the eric-wieser/pi-tensor-product-induction branch February 24, 2024 01:44
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
…0904)

This looks much nicer in the `induction` tactic than `C1` and `Cp`, as
```lean
induction a using PiTensorProduct.induction_on with
| smul_tprod r a => sorry
| add x y hx hy => sorry
```
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
…0904)

This looks much nicer in the `induction` tactic than `C1` and `Cp`, as
```lean
induction a using PiTensorProduct.induction_on with
| smul_tprod r a => sorry
| add x y hx hy => sorry
```
Louddy pushed a commit that referenced this pull request Apr 15, 2024
…0904)

This looks much nicer in the `induction` tactic than `C1` and `Cp`, as
```lean
induction a using PiTensorProduct.induction_on with
| smul_tprod r a => sorry
| add x y hx hy => sorry
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants