[Merged by Bors] - chore(GroupTheory/Perm/Cycle/Basic): Split #10907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
reviewed
Feb 24, 2024
There was a problem hiding this comment.
Sorry, I'm really not convinced by this split. Please just ignore the linter in #9602 (you can edit the nolint entry). I will split the file later.
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
added 4 commits
February 24, 2024 15:26
AntoineChambert-Loir
added
the
awaiting-review
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
jcommelin
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
@YaelDillies I don't understand what is so terrible about this split. I think it is a clear improvement over the status quo, and you're of course free to improve further in the future.
I agree that it's an improvement. I propose to merge it unless there a specific reason against it (also it risks to rot). |
jcommelin
changed the title
YaelDillies
changed the title
YaelDillies
reviewed
Feb 29, 2024
Comment on lines
+21
to
+22
| The main definition of this file is `Equiv.Perm.sign`, | ||
| associating a `ℤˣ` sign with a permutation. |
There was a problem hiding this comment.
Suggested change
| The main definition of this file is `Equiv.Perm.sign`, | |
| associating a `ℤˣ` sign with a permutation. | |
| The main definition of this file is `Equiv.Perm.sign`, associating a `ℤˣ` sign with a | |
| permutation. |
There was a problem hiding this comment.
I'm personally a fan of semantic linebreaks (https://sembr.org/).
We don't have a policy in mathlib concerning sembr or justifying text. I would leave this as it is.
There was a problem hiding this comment.
(That's not the subject here, but I am used to 80 chars terminals, and I find these overflow to 100 chars very disturbing, I get many lines with few symbols, hence less information on my screen.)
There was a problem hiding this comment.
Can you split off that split to its own PR? This one is getting out of hand
There was a problem hiding this comment.
I would prefer not to.
There was a problem hiding this comment.
Reverting the change to Sign would mean finding what to move and rechecking imports. The handful of lemmas I moved were about something else than Sign — just needed for that.
IIRC, some files that used Sign could stop using it.
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
The file Mathlib.GroupTheory.Perm.Cycle.Basic was too big and this PR splits it in several components: * `Mathlib.GroupTheory.Perm.Cycle.Basic` contains everything related to a permutation being a cycle, * `Mathlib.GroupTheory.Perm.Cycle.Factors` is about the cycles of a permutation and the decomposition of a permutation into disjoint cycles * `Mathlib.GroupTheory.Perm.Closure` contains generation results for the permutation groups * `Mathlib.GroupTheory.Perm.Finite` contains general results specific to permutation of finite types I moved some results to `Mathlib.GroupTheory.Perm.Support` I also moved some results from `Mathlib.GroupTheory.Perm.Sign` to `Mathlib.GroupTheory.Perm.Finite` Some imports could be reduced, and the shake linter required a few adjustments in some other. Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@math.univ-paris-diderot.fr>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
kbuzzard
pushed a commit
that referenced
this pull request
Mar 12, 2024
The file Mathlib.GroupTheory.Perm.Cycle.Basic was too big and this PR splits it in several components: * `Mathlib.GroupTheory.Perm.Cycle.Basic` contains everything related to a permutation being a cycle, * `Mathlib.GroupTheory.Perm.Cycle.Factors` is about the cycles of a permutation and the decomposition of a permutation into disjoint cycles * `Mathlib.GroupTheory.Perm.Closure` contains generation results for the permutation groups * `Mathlib.GroupTheory.Perm.Finite` contains general results specific to permutation of finite types I moved some results to `Mathlib.GroupTheory.Perm.Support` I also moved some results from `Mathlib.GroupTheory.Perm.Sign` to `Mathlib.GroupTheory.Perm.Finite` Some imports could be reduced, and the shake linter required a few adjustments in some other. Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@math.univ-paris-diderot.fr>
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
The file Mathlib.GroupTheory.Perm.Cycle.Basic was too big and this PR splits it in several components: * `Mathlib.GroupTheory.Perm.Cycle.Basic` contains everything related to a permutation being a cycle, * `Mathlib.GroupTheory.Perm.Cycle.Factors` is about the cycles of a permutation and the decomposition of a permutation into disjoint cycles * `Mathlib.GroupTheory.Perm.Closure` contains generation results for the permutation groups * `Mathlib.GroupTheory.Perm.Finite` contains general results specific to permutation of finite types I moved some results to `Mathlib.GroupTheory.Perm.Support` I also moved some results from `Mathlib.GroupTheory.Perm.Sign` to `Mathlib.GroupTheory.Perm.Finite` Some imports could be reduced, and the shake linter required a few adjustments in some other. Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@math.univ-paris-diderot.fr>
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
The file Mathlib.GroupTheory.Perm.Cycle.Basic was too big and this PR splits it in several components: * `Mathlib.GroupTheory.Perm.Cycle.Basic` contains everything related to a permutation being a cycle, * `Mathlib.GroupTheory.Perm.Cycle.Factors` is about the cycles of a permutation and the decomposition of a permutation into disjoint cycles * `Mathlib.GroupTheory.Perm.Closure` contains generation results for the permutation groups * `Mathlib.GroupTheory.Perm.Finite` contains general results specific to permutation of finite types I moved some results to `Mathlib.GroupTheory.Perm.Support` I also moved some results from `Mathlib.GroupTheory.Perm.Sign` to `Mathlib.GroupTheory.Perm.Finite` Some imports could be reduced, and the shake linter required a few adjustments in some other. Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@math.univ-paris-diderot.fr>
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
The file Mathlib.GroupTheory.Perm.Cycle.Basic was too big and this PR splits it in several components: * `Mathlib.GroupTheory.Perm.Cycle.Basic` contains everything related to a permutation being a cycle, * `Mathlib.GroupTheory.Perm.Cycle.Factors` is about the cycles of a permutation and the decomposition of a permutation into disjoint cycles * `Mathlib.GroupTheory.Perm.Closure` contains generation results for the permutation groups * `Mathlib.GroupTheory.Perm.Finite` contains general results specific to permutation of finite types I moved some results to `Mathlib.GroupTheory.Perm.Support` I also moved some results from `Mathlib.GroupTheory.Perm.Sign` to `Mathlib.GroupTheory.Perm.Finite` Some imports could be reduced, and the shake linter required a few adjustments in some other. Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@math.univ-paris-diderot.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file Mathlib.GroupTheory.Perm.Cycle.Basic was too big and this PR splits it in several components:
Mathlib.GroupTheory.Perm.Cycle.Basiccontains everything related to a permutation being a cycle,Mathlib.GroupTheory.Perm.Cycle.Factorsis about the cycles of a permutation and the decomposition of a permutation into disjoint cyclesMathlib.GroupTheory.Perm.Closurecontains generation results for the permutation groupsMathlib.GroupTheory.Perm.Finitecontains general results specific to permutation of finite typesI moved some results to
Mathlib.GroupTheory.Perm.SupportI also moved some results from
Mathlib.GroupTheory.Perm.SigntoMathlib.GroupTheory.Perm.FiniteSome imports could be reduced, and the shake linter required a few adjustments in some other.