[Merged by Bors] - chore(diamonds): appropriate transparency levels for diamond checks #10910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobball
added
the
awaiting-review
eric-wieser
reviewed
Feb 24, 2024
kbuzzard
reviewed
Feb 24, 2024
|
Now includes |
1 task
|
bors merge Thanks! |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 24, 2024
…10910) Currently, we have multiple "no-diamond" tests of the form ```lean example : x = y := rfl ``` where `X` and `Y` are instances of some `class`. The problem is that since `simp` and type class synthesis operate at `reducible_and_instances` transparency this check means little. We went through all the mentions of diamonds and either added `with_reducible_and_instancse` or added a reference to the issue #10906. Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
…10910) Currently, we have multiple "no-diamond" tests of the form ```lean example : x = y := rfl ``` where `X` and `Y` are instances of some `class`. The problem is that since `simp` and type class synthesis operate at `reducible_and_instances` transparency this check means little. We went through all the mentions of diamonds and either added `with_reducible_and_instancse` or added a reference to the issue #10906. Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
…10910) Currently, we have multiple "no-diamond" tests of the form ```lean example : x = y := rfl ``` where `X` and `Y` are instances of some `class`. The problem is that since `simp` and type class synthesis operate at `reducible_and_instances` transparency this check means little. We went through all the mentions of diamonds and either added `with_reducible_and_instancse` or added a reference to the issue #10906. Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
…10910) Currently, we have multiple "no-diamond" tests of the form ```lean example : x = y := rfl ``` where `X` and `Y` are instances of some `class`. The problem is that since `simp` and type class synthesis operate at `reducible_and_instances` transparency this check means little. We went through all the mentions of diamonds and either added `with_reducible_and_instancse` or added a reference to the issue #10906. Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have multiple "no-diamond" tests of the form
example : x = y := rflwhere
XandYare instances of someclass. The problem is that sincesimpand type class synthesis operate atreducible_and_instancestransparency this check means little.We went through all the mentions of diamonds and either added
with_reducible_and_instancseor added a reference to the issue #10906.