Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Measure.MeasureSpace): clean up uses of @ #10932

Closed
wants to merge 8 commits into from

Conversation

mattrobball
Copy link
Collaborator

@mattrobball mattrobball commented Feb 24, 2024

We eliminate all possible uses of @'s either through deletion or replacement with an explicit argument. A comment about a diamond is slightly clarified to point at #10941.


Open in Gitpod

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 24, 2024
@@ -618,7 +618,8 @@ theorem measure_liminf_eq_zero {s : ℕ → Set α} (h : (∑' i, μ (s i)) ≠
#align measure_theory.measure_liminf_eq_zero MeasureTheory.measure_liminf_eq_zero

theorem limsup_ae_eq_of_forall_ae_eq (s : ℕ → Set α) {t : Set α}
(h : ∀ n, s n =ᵐ[μ] t) : @limsup (Set α) ℕ _ s atTop =ᵐ[μ] t := by
(h : ∀ n, s n =ᵐ[μ] t) : limsup (α := Set α) s atTop =ᵐ[μ] t := by
-- Need to specify `α := Set α` above because of diamond; see gh issue #16932
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#16932 doesn't exist; is this leanprover-community/mathlib#16932 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expanded

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open a new issue for mathlib 4 with a lean 4 mwe, and reference that

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 24, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

@eric-wieser
Copy link
Member

Can you merge master to shrink the diff?

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Feb 25, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 25, 2024
We eliminate all possible uses of `@`'s either through deletion or replacement with an explicit argument. A comment about a diamond is slightly clarified.



Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 25, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Measure.MeasureSpace): clean up uses of @ [Merged by Bors] - chore(Measure.MeasureSpace): clean up uses of @ Feb 25, 2024
@mathlib-bors mathlib-bors bot closed this Feb 25, 2024
@mathlib-bors mathlib-bors bot deleted the mrb/clean_up_ats_measure_meas_space branch February 25, 2024 09:42
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
We eliminate all possible uses of `@`'s either through deletion or replacement with an explicit argument. A comment about a diamond is slightly clarified.



Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
We eliminate all possible uses of `@`'s either through deletion or replacement with an explicit argument. A comment about a diamond is slightly clarified.



Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Louddy pushed a commit that referenced this pull request Apr 15, 2024
We eliminate all possible uses of `@`'s either through deletion or replacement with an explicit argument. A comment about a diamond is slightly clarified.



Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants