[Merged by Bors] - chore(Order/Lattice): Resolve porting notes #11034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The `dsimp` issue has been resolved. * I knew that the lemmas provable by `simp` were provable by `simp` in Lean 3, but the simp nf linter was more lax. Now there's definitely no need to tag them. * `ematch` is not coming back (and was already completely unused for years in Lean 3). * Unification has changed in Lean 4, so it's really unsurprising that we need to provide an extra argument to `sup_ind`. It's not expectable that this will ever change, neither is it necessary. * Dot notation on `Function.update` is still broken. This is the last remaining porting note.
YaelDillies
added
awaiting-review
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
* The `dsimp` issue has been resolved. * I knew that the lemmas provable by `simp` were provable by `simp` in Lean 3, but the simp nf linter was more lax. Now there's definitely no need to tag them. * `ematch` is not coming back (and was already completely unused for years in Lean 3). * Unification has changed in Lean 4, so it's really unsurprising that we need to provide an extra argument to `sup_ind`. It's not expectable that this will ever change, neither is it necessary. * Dot notation on `Function.update` is still broken. This is the last remaining porting note.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
* The `dsimp` issue has been resolved. * I knew that the lemmas provable by `simp` were provable by `simp` in Lean 3, but the simp nf linter was more lax. Now there's definitely no need to tag them. * `ematch` is not coming back (and was already completely unused for years in Lean 3). * Unification has changed in Lean 4, so it's really unsurprising that we need to provide an extra argument to `sup_ind`. It's not expectable that this will ever change, neither is it necessary. * Dot notation on `Function.update` is still broken. This is the last remaining porting note.
kbuzzard
pushed a commit
that referenced
this pull request
Mar 12, 2024
* The `dsimp` issue has been resolved. * I knew that the lemmas provable by `simp` were provable by `simp` in Lean 3, but the simp nf linter was more lax. Now there's definitely no need to tag them. * `ematch` is not coming back (and was already completely unused for years in Lean 3). * Unification has changed in Lean 4, so it's really unsurprising that we need to provide an extra argument to `sup_ind`. It's not expectable that this will ever change, neither is it necessary. * Dot notation on `Function.update` is still broken. This is the last remaining porting note.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
* The `dsimp` issue has been resolved. * I knew that the lemmas provable by `simp` were provable by `simp` in Lean 3, but the simp nf linter was more lax. Now there's definitely no need to tag them. * `ematch` is not coming back (and was already completely unused for years in Lean 3). * Unification has changed in Lean 4, so it's really unsurprising that we need to provide an extra argument to `sup_ind`. It's not expectable that this will ever change, neither is it necessary. * Dot notation on `Function.update` is still broken. This is the last remaining porting note.
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
* The `dsimp` issue has been resolved. * I knew that the lemmas provable by `simp` were provable by `simp` in Lean 3, but the simp nf linter was more lax. Now there's definitely no need to tag them. * `ematch` is not coming back (and was already completely unused for years in Lean 3). * Unification has changed in Lean 4, so it's really unsurprising that we need to provide an extra argument to `sup_ind`. It's not expectable that this will ever change, neither is it necessary. * Dot notation on `Function.update` is still broken. This is the last remaining porting note.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dsimpissue has been resolved.simpwere provable bysimpin Lean 3, but the simp nf linter was more lax. Now there's definitely no need to tag them.ematchis not coming back (and was already completely unused for years in Lean 3).sup_ind. It's not expectable that this will ever change, neither is it necessary.Function.updateis still broken. This is the last remaining porting note.