Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Order/Lattice): Resolve porting notes #11034

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(Order/Lattice): Resolve porting notes #11034

wants to merge 1 commit into from

Commits on Feb 28, 2024

  1. chore(Order/Lattice): Resolve porting notes 

    * The `dsimp` issue has been resolved.
* I knew that the lemmas provable by `simp` were provable by `simp` in Lean 3, but the simp nf linter was more lax. Now there's definitely no need to tag them.
* `ematch` is not coming back (and was already completely unused for years in Lean 3).
* Unification has changed in Lean 4, so it's really unsurprising that we need to provide an extra argument to `sup_ind`. It's not expectable that this will ever change, neither is it necessary.
* Dot notation on `Function.update` is still broken. This is the last remaining porting note.
    @YaelDillies
    YaelDillies committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    2eb5ccd View commit details
    Browse the repository at this point in the history