-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(RingTheory/Trace): Define TraceForm
with LinearMap.BilinForm
#11057
Closed
Closed
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
06b0a2a
WIP
mans0954 7cb466f
Add missing SesquilinearForm Properties
mans0954 a6d1fbd
Start to base some BilinearForm Properties on SesquilinearForm Proper…
mans0954 74a0c2a
Try to get trace working
mans0954 294f49b
Add missing SesquilinearForm Properties
mans0954 443286b
Start to base some BilinearForm Properties on SesquilinearForm Proper…
mans0954 5279a56
Bilin defs
mans0954 8d1439c
Reorg
mans0954 af4ef19
Add missing file
mans0954 7b7e900
Refactor
mans0954 ee64096
Reference LinearMap.BilinForm form all properties
mans0954 236ed91
Rename Nondegenerate to SeparatingLeft
mans0954 790fd14
Remove duplicate align statements
mans0954 eb4635d
Reorg
mans0954 824c584
DualLattice
mans0954 02c151b
BilinearForm/DualLattice using SesquilinearForm/DualLattice
mans0954 911e2d7
Remove noise
mans0954 ea04358
Remove noise
mans0954 fa8f320
Remove unused vars
mans0954 16e7d1e
Fix
mans0954 52ac3fe
Merge branch 'mans0954/SesquilinearForm-Properties' into mans0954/bil…
mans0954 8733ad7
Fix
mans0954 b0e31b5
Shake
mans0954 93cbd4d
Build
mans0954 95c7382
Build
mans0954 d2b712e
Merge branch 'master' into mans0954/bilinform-trace
mans0954 0bc3733
Merge branch 'master' into mans0954/bilinform-trace
mans0954 4c17dd2
Fix
mans0954 d3eb490
Remove comment
mans0954 ae5b45a
lake exe shake --fix
mans0954 9cf5b3c
Merge branch 'master' into mans0954/bilinform-trace
mans0954 0716592
Merge branch 'master' into mans0954/bilinform-trace
mans0954 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why erasing
traceForm_nondegenerate
? Even iftraceForm_separatingLeft
is stronger we can have both (as a lot of people will look for nondegeneracy).