Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Real.CauSeq #1124

Closed
wants to merge 43 commits into from
Closed

[Merged by Bors] - feat: port Data.Real.CauSeq #1124

wants to merge 43 commits into from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented Dec 20, 2022 •
edited by github-actions bot

@mcdoll mcdoll added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Dec 20, 2022
@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Dec 26, 2022
dupuisf
dupuisf reviewed Dec 26, 2022
View reviewed changes
Mathlib/Algebra/Group/Pi.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Group/Pi.lean Outdated Show resolved Hide resolved
Mathlib/Data/Real/CauSeq.lean Outdated Show resolved Hide resolved
Mathlib/Data/Real/CauSeq.lean Outdated Show resolved Hide resolved
Mathlib/Data/Real/CauSeq.lean Outdated Show resolved Hide resolved
Mathlib/Data/Real/CauSeq.lean Outdated Show resolved Hide resolved
Mathlib/Data/Real/CauSeq.lean Outdated Show resolved Hide resolved
eric-wieser
eric-wieser reviewed Dec 26, 2022
View reviewed changes
Mathlib/Data/Real/CauSeq.lean Outdated Show resolved Hide resolved
Mathlib/Data/Real/CauSeq.lean Outdated Show resolved Hide resolved
@dupuisf dupuisf added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 27, 2022
@mcdoll mcdoll added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 7, 2023
@eric-wieser
Copy link
Member

eric-wieser commented Jan 7, 2023 •
edited

here's the new mathport diff. Can you restore the abv proofs in rat_mul_continuous_lemma and rat_inv_continuous_lemma that were messed with before we fixed the root cause?

Ruben-VandeVelde
Ruben-VandeVelde approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ruben-VandeVelde Ruben-VandeVelde mentioned this pull request Jan 9, 2023
Closed
1 task
jcommelin
jcommelin approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 10, 2023
bors bot pushed a commit that referenced this pull request Jan 10, 2023
@mcdoll @eric-wieser
@ChrisHughes24 @hrmacbeth
feat: port Data.Real.CauSeq (#1124)
550e290 
- [x] depends on: #1398

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 10, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Real.CauSeq [Merged by Bors] - feat: port Data.Real.CauSeq Jan 10, 2023
@bors bors bot closed this Jan 10, 2023
@bors bors bot deleted the mcdoll/data_real_causeq branch January 10, 2023 07:01
bors bot pushed a commit that referenced this pull request Jan 10, 2023
@mcdoll @eric-wieser
@ChrisHughes24 @hrmacbeth
feat: port Mathlib.Data.Real.CauSeqCompletion (#1440)
0a713e2 
- [x] depends on: #1124

This is quite painful due to `parameter` use in mathlib3.

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@mcdoll @eric-wieser
@ChrisHughes24 @hrmacbeth @jcommelin
feat: port Data.Real.CauSeq (#1124)
79b47a9 
- [x] depends on: #1398

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@mcdoll @eric-wieser
@ChrisHughes24 @hrmacbeth @jcommelin
feat: port Mathlib.Data.Real.CauSeqCompletion (#1440)
d819274 
- [x] depends on: #1124

This is quite painful due to `parameter` use in mathlib3.

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@digama0 digama0 digama0 left review comments

@dupuisf dupuisf dupuisf left review comments

@jcommelin jcommelin jcommelin approved these changes

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@mcdoll @eric-wieser @semorrison @digama0 @jcommelin @dupuisf @Ruben-VandeVelde @ChrisHughes24 @hrmacbeth