Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Mathlib.Data.Real.CauSeqCompletion #1440

Closed
wants to merge 56 commits into from
Closed

[Merged by Bors] - feat: port Mathlib.Data.Real.CauSeqCompletion #1440

wants to merge 56 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde commented Jan 9, 2023 •
edited by jcommelin
Loading

This is quite painful due to parameter use in mathlib3.

mcdoll and others added 30 commits December 21, 2022 01:22
@mcdoll
initial commit
85a405e
@mcdoll
fixes
da883b1
@mcdoll
linter
f5cea7f
@mcdoll
fixes
0c29c34
@mcdoll
sorried out errors
1e94c0c
@mcdoll
merge and fixes
f806297
@mcdoll
more fixes
52f6f16
@mcdoll
coercion hell?
cd651a6
@mcdoll
Merge branch 'master' of github.com:leanprover-community/mathlib4 int…
0018c81 
…o mcdoll/data_real_causeq
@mcdoll
one diamond left
f5b2070
@mcdoll
Merge branch 'master' of github.com:leanprover-community/mathlib4 int…
527a84a 
…o mcdoll/data_real_causeq
@eric-wieser
further narrow down the problem
d4ab366
@eric-wieser
fix
d077298
@mcdoll
Merge remote-tracking branch 'origin' into mcdoll/data_real_causeq
809e0f6
@ChrisHughes24
fix build
f7dd2da
@ChrisHughes24
comment changes
c53e87c
@ChrisHughes24
fix linting errors
1116f94
@ChrisHughes24
line length
30a934b
@ChrisHughes24
import in Mathlib.lean
2eadb4a
@ChrisHughes24
line length
65ae900
@eric-wieser
Merge remote-tracking branch 'origin/master' into mcdoll/data_real_ca…
1d02cb2 
…useq
@hrmacbeth
Merge branch 'master' into mcdoll/data_real_causeq
4099908
@ChrisHughes24
Merge remote-tracking branch 'origin/master' into mcdoll/data_real_ca…
0bf084b 
…useq
@ChrisHughes24 @dupuisf
Apply suggestions from code review
41bb79d 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@ChrisHughes24
lim_zero renaming
b24bd0a
@ChrisHughes24
delete commented code
0a717fb
@ChrisHughes24
add noalign
567c090
@ChrisHughes24
restore norm_cast attributes
6f3b673
@ChrisHughes24
add Porting note:
619a90e
@eric-wieser
add latest mathport
3ba5e5f
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 10, 2023
@eric-wieser
Copy link
Member

eric-wieser commented Jan 10, 2023 •
edited
Loading

This is quite painful due to parameter use in mathlib3.

Perhaps we should remove the parameters in mathlib3, and make the abv argument explicit? (edit: leanprover-community/mathlib#18122)

@LukasMias
Copy link
Collaborator

This is good now except for the unsafe instance at line 284, which goes way above my head. I did not even know that intercalate is a word!

@Ruben-VandeVelde Ruben-VandeVelde removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Jan 10, 2023
@jcommelin
Copy link
Member

LGTM!

But Heather's suggestion is still open.

jcommelin
jcommelin approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jan 10, 2023
bors bot pushed a commit that referenced this pull request Jan 10, 2023
@mcdoll @eric-wieser
@ChrisHughes24 @hrmacbeth
feat: port Mathlib.Data.Real.CauSeqCompletion (#1440)
0a713e2 
- [x] depends on: #1124

This is quite painful due to `parameter` use in mathlib3.

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 10, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Mathlib.Data.Real.CauSeqCompletion [Merged by Bors] - feat: port Mathlib.Data.Real.CauSeqCompletion Jan 10, 2023
@bors bors bot closed this Jan 10, 2023
@bors bors bot deleted the port/Data.Real.CauSeqCompletion branch January 10, 2023 21:18
eric-wieser added a commit that referenced this pull request Jan 10, 2023
@eric-wieser
Revert "feat: port Mathlib.Data.Real.CauSeqCompletion (#1440)"
7a59ec6 
This reverts commit 0a713e2.

The motivation is to allow leanprover-community/mathlib#18122 to generate pre-port mathport output in the mathlib3port CI.
Once that is done, I will unrevert this and merge in the changes it suggests.
bors bot pushed a commit that referenced this pull request Jan 10, 2023
@eric-wieser
Revert "feat: port Mathlib.Data.Real.CauSeqCompletion (#1440)" (#1468)
771dfd4 
This reverts commit 0a713e2.

The motivation is to allow leanprover-community/mathlib#18122 to generate pre-port mathport output in the mathlib3port CI. Once that is done, I will unrevert this and merge in the changes it suggests.
eric-wieser added a commit that referenced this pull request Jan 10, 2023
@eric-wieser
Revert "Revert "feat: port Mathlib.Data.Real.CauSeqCompletion (#1440)" (
c0ee4cf 
#1468)"

This reverts commit 771dfd4.
@eric-wieser eric-wieser mentioned this pull request Jan 10, 2023
Closed
2 tasks
bors bot pushed a commit that referenced this pull request Jan 13, 2023
@eric-wieser @Ruben-VandeVelde
feat: port Data.Real.CauSeqCompletion (#1469)
d4e2fbc 
Unreverts #1440




Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@mcdoll @eric-wieser
@ChrisHughes24 @hrmacbeth @jcommelin
feat: port Mathlib.Data.Real.CauSeqCompletion (#1440)
d819274 
- [x] depends on: #1124

This is quite painful due to `parameter` use in mathlib3.

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@eric-wieser @jcommelin
Revert "feat: port Mathlib.Data.Real.CauSeqCompletion (#1440)" (#1468)
72c7dff 
This reverts commit 0a713e2.

The motivation is to allow leanprover-community/mathlib#18122 to generate pre-port mathport output in the mathlib3port CI. Once that is done, I will unrevert this and merge in the changes it suggests.
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@eric-wieser @Ruben-VandeVelde @jcommelin
feat: port Data.Real.CauSeqCompletion (#1469)
6102753 
Unreverts #1440




Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrmacbeth hrmacbeth hrmacbeth left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Ruben-VandeVelde @semorrison @eric-wieser @LukasMias @jcommelin @hrmacbeth @mcdoll @ChrisHughes24 @qawbecrdtey