Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.OmegaCompletePartialOrder #1168

Closed
wants to merge 23 commits into from
Closed

[Merged by Bors] - feat: port Order.OmegaCompletePartialOrder #1168

wants to merge 23 commits into from

Conversation

rwbarton
Copy link
Contributor

@rwbarton rwbarton commented Dec 22, 2022 •
edited by github-actions bot

@rwbarton rwbarton added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Dec 22, 2022
@rwbarton
Copy link
Contributor Author

leanprover/lean4#1937 makes this too unpleasant for now.

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 28, 2022
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 31, 2022
@hrmacbeth
Copy link
Member

leanprover/lean4#1937 makes this too unpleasant for now.

Hopefully fixed after the bump to nightly-2023-01-06.

@semorrison semorrison added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Jan 7, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

Ruben-VandeVelde
Ruben-VandeVelde reviewed Jan 12, 2023
View reviewed changes
Mathlib/Order/OmegaCompletePartialOrder.lean Outdated
Comment on lines 532 to 533
simp only [inf_le_iff, hf c, hg c, ωSup_le_iff, ← forall_or_left, ← forall_or_right,
Function.comp_apply, Chain.map_coe, OrderHom.orderBot] -- something broken here
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like inf_le_iff no longer applies. Trying to force it gets me to a @SemilatticeInf.toHasInf β Lattice.toSemilatticeInf = @Lattice.toHasInf β LinearOrder.toLattice goal.

Also the lemma now known as OrderHom.instHasInfOrderHomToPreorderToPartialOrder_inf_coe is missing from the simp call

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this problem with inf_le_iff no longer applying.

@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 17, 2023
ericrbg
ericrbg approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@ericrbg ericrbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

Mathlib/Order/OmegaCompletePartialOrder.lean Outdated Show resolved Hide resolved
jcommelin and others added 2 commits January 20, 2023 06:50
@jcommelin @ericrbg
Update Mathlib/Order/OmegaCompletePartialOrder.lean
2a9184b 
Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
@jcommelin
Merge remote-tracking branch 'origin/master' into Order.OmegaComplete…
c3c964e 
…PartialOrder
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 20, 2023
bors bot pushed a commit that referenced this pull request Jan 20, 2023
@rwbarton @hrmacbeth
@jcommelin @semorrison @ChrisHughes24 @Ruben-VandeVelde
feat: port Order.OmegaCompletePartialOrder (#1168)
27b1665 
- [x] depends on: #1397

Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 20, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.OmegaCompletePartialOrder [Merged by Bors] - feat: port Order.OmegaCompletePartialOrder Jan 20, 2023
@bors bors bot closed this Jan 20, 2023
@bors bors bot deleted the Order.OmegaCompletePartialOrder branch January 20, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@ChrisHughes24 ChrisHughes24 ChrisHughes24 left review comments

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde left review comments

@ericrbg ericrbg ericrbg approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rwbarton @hrmacbeth @semorrison @jcommelin @ChrisHughes24 @ericrbg @Ruben-VandeVelde