[Merged by Bors] - chore: move FiniteDimensional.trans higher up the import hierarchy
#12079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaël pointed out that the import `Data.Complex.Module → FieldTheory.Tower` brings with it too many things. The only declaration from `FieldTheory.Tower` needed for `Data.Complex.Module` is `FiniteDimensional.trans`, which we can easily move up the import hierarchy (14 imports higher, in fact). So this means we can cut the long pole of Mathlib by up to 13 files. Specific Zulip discussion starts here: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/The.20long.20pole.20in.20mathlib/near/432796670
Vierkantor
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
…12079) @YaelDillies pointed out that the import `Data.Complex.Module → FieldTheory.Tower` brings with it too many things. The only declaration from `FieldTheory.Tower` needed for `Data.Complex.Module` is `FiniteDimensional.trans`, which we can easily move up the import hierarchy (14 imports higher, in fact). So this means we can cut the long pole of Mathlib by up to 13 files. Specific Zulip discussion starts here: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/The.20long.20pole.20in.20mathlib/near/432796670
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
FiniteDimensional.trans higher up the import hierarchyFiniteDimensional.trans higher up the import hierarchy
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
…12079) @YaelDillies pointed out that the import `Data.Complex.Module → FieldTheory.Tower` brings with it too many things. The only declaration from `FieldTheory.Tower` needed for `Data.Complex.Module` is `FiniteDimensional.trans`, which we can easily move up the import hierarchy (14 imports higher, in fact). So this means we can cut the long pole of Mathlib by up to 13 files. Specific Zulip discussion starts here: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/The.20long.20pole.20in.20mathlib/near/432796670
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
…12079) @YaelDillies pointed out that the import `Data.Complex.Module → FieldTheory.Tower` brings with it too many things. The only declaration from `FieldTheory.Tower` needed for `Data.Complex.Module` is `FiniteDimensional.trans`, which we can easily move up the import hierarchy (14 imports higher, in fact). So this means we can cut the long pole of Mathlib by up to 13 files. Specific Zulip discussion starts here: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/The.20long.20pole.20in.20mathlib/near/432796670
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
…12079) @YaelDillies pointed out that the import `Data.Complex.Module → FieldTheory.Tower` brings with it too many things. The only declaration from `FieldTheory.Tower` needed for `Data.Complex.Module` is `FiniteDimensional.trans`, which we can easily move up the import hierarchy (14 imports higher, in fact). So this means we can cut the long pole of Mathlib by up to 13 files. Specific Zulip discussion starts here: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/The.20long.20pole.20in.20mathlib/near/432796670
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
…12079) @YaelDillies pointed out that the import `Data.Complex.Module → FieldTheory.Tower` brings with it too many things. The only declaration from `FieldTheory.Tower` needed for `Data.Complex.Module` is `FiniteDimensional.trans`, which we can easily move up the import hierarchy (14 imports higher, in fact). So this means we can cut the long pole of Mathlib by up to 13 files. Specific Zulip discussion starts here: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/The.20long.20pole.20in.20mathlib/near/432796670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@YaelDillies pointed out that the import
Data.Complex.Module → FieldTheory.Towerbrings with it too many things. The only declaration fromFieldTheory.Towerneeded forData.Complex.ModuleisFiniteDimensional.trans, which we can easily move up the import hierarchy (14 imports higher, in fact). So this means we can cut the long pole of Mathlib by up to 13 files.Specific Zulip discussion starts here: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/The.20long.20pole.20in.20mathlib/near/432796670
I'm still awaiting the results of
shake. Hopefully we can optimize a few more imports with this change.