Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: move FiniteDimensional.trans higher up the import hierarchy #12079

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: move FiniteDimensional.trans higher up the import hierarchy #12079

wants to merge 2 commits into from

Commits on Apr 12, 2024

  1. chore: move FiniteDimensional.trans higher up the import hierarchy 

    Yaël pointed out that the import `Data.Complex.Module → FieldTheory.Tower` brings with it too many things. The only declaration from `FieldTheory.Tower` needed for `Data.Complex.Module` is `FiniteDimensional.trans`, which we can easily move up the import hierarchy (14 imports higher, in fact). So this means we can cut the long pole of Mathlib by up to 13 files.

Specific Zulip discussion starts here: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/The.20long.20pole.20in.20mathlib/near/432796670
    @Vierkantor
    Vierkantor committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    306b01e View commit details
    Browse the repository at this point in the history

  2. Reduce imports further

    @Vierkantor
    Vierkantor committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8860e44 View commit details
    Browse the repository at this point in the history