[Merged by Bors] - chore: fix more casing errors per naming scheme #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
the
merge-conflict
semorrison
removed
the
merge-conflict
hrmacbeth
reviewed
Jan 2, 2023
| @@ -240,7 +240,7 @@ instance (priority := 70) (R : Type _) [e : EuclideanDomain R] : NoZeroDivisors | |||
|
|
|||
| -- see Note [lower instance priority] | |||
| instance (priority := 70) (R : Type _) [e : EuclideanDomain R] : IsDomain R := | |||
| { e, NoZeroDivisors.toIsDomain R with } | |||
| { e, NoZeroDivisors.to_isDomain R with } | |||
There was a problem hiding this comment.
The to might be a special case? See the example MonoidHom.toOneHom_injective in the naming convention guide.
There was a problem hiding this comment.
My understanding is, since IsDomain is a Prop, to_isDomain should follow the convention for proofs, i.e. snake case. On the other hand, toOneHom contains data, so its name should be lower camel case.
hrmacbeth
added
awaiting-author
winstonyin
added
awaiting-review
and removed
awaiting-author
semorrison
added
the
merge-conflict
semorrison
removed
the
merge-conflict
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 3, 2023
I've avoided anything under `Tactic` or `test`. In correcting the names, I found `Option.isNone_iff_eq_none` duplicated between `Std` and `Mathlib`, so the `Mathlib` one has been removed. Co-authored-by: Reid Barton <rwbarton@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've avoided anything under
Tacticortest.In correcting the names, I found
Option.isNone_iff_eq_noneduplicated betweenStdandMathlib, so theMathlibone has been removed.