-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(CategoryTheory): morphism properties that have the two-out-of-three property #12460
Conversation
…o-out-of-three-property
simpa only [← F.map_comp] using h (F.map f) (F.map g) hf hg | ||
#align category_theory.morphism_property.stable_under_composition.inverse_image CategoryTheory.MorphismProperty.StableUnderComposition.inverseImage | ||
theorem respectsIso_of_isStableUnderComposition {P : MorphismProperty C} | ||
[P.IsStableUnderComposition] (hP : isomorphisms C ⊆ P) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that a lot of these are formalized with subset rather than le. Is there a reason to this? It will require either a lot more duplication or rewrites into le when using the order API (when considering the disjunction of properties, or monotone property constructors etc.)
(out of scope of this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For MorphismProperty
, I prefer ⊆
over ≤
, because if h : W₁ ⊆ W₂
, it can be used as h f hf
, rather than h X Y f hf
if it were h : W₁ ≤ W₂
(and f : X ⟶ Y
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm good point. I'll try later if I can change up the implicitness when deriving the complete lattice instance.
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
!bench |
Here are the benchmark results for commit 70e66e2. |
Thanks! |
🚀 Pull request has been placed on the maintainer queue by erdOne. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
…ree property (#12460) The type class `MorphismProperty.HasTwoOutOfThreeProperty` is introduced. The structure `StableUnderComposition` is also changed into a type class `IsStableUnderComposition`. Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
…ree property (#12460) The type class `MorphismProperty.HasTwoOutOfThreeProperty` is introduced. The structure `StableUnderComposition` is also changed into a type class `IsStableUnderComposition`. Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
…ree property (#12460) The type class `MorphismProperty.HasTwoOutOfThreeProperty` is introduced. The structure `StableUnderComposition` is also changed into a type class `IsStableUnderComposition`. Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
The type class
MorphismProperty.HasTwoOutOfThreeProperty
is introduced. The structureStableUnderComposition
is also changed into a type classIsStableUnderComposition
.