Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Order.Zorn #1254

Closed
wants to merge 12 commits into from
Closed

Conversation

ADedecker
Copy link
Member

@ADedecker ADedecker commented Dec 29, 2022

No description provided.

@ADedecker ADedecker added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Dec 29, 2022
@hrmacbeth hrmacbeth added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Dec 31, 2022
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Order/Zorn.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 1, 2023

✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jan 1, 2023
@hrmacbeth
Copy link
Member

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 1, 2023
bors bot pushed a commit that referenced this pull request Jan 1, 2023
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 1, 2023

Build failed:

  • Build

@hrmacbeth
Copy link
Member

It failed to build, apparently complaining about the local notation already being used in another file:

./././Mathlib.lean:1:0: error: import Mathlib.Order.Zorn failed, environment already contains
'«term_≺__3»._closed_6._cstage2' from Mathlib.Algebra.Order.EuclideanAbsoluteValue

Strange because this file successfully built before. I don't know if the problem was in deleting the comment

-- mathport name: «expr ≺ »

or in merging master. I'll try merging master first.

@ADedecker
Copy link
Member Author

ADedecker commented Jan 1, 2023

I've encountered this before, this is a bug (see here). The temporary fix is to give a name to the notation. I'm not at my computer right now, but you can have a look at what I did in Order.Antichain and Order.Chain to see the syntax for naming notations.

@hrmacbeth
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 1, 2023
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 1, 2023

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@bors bors bot changed the title feat: port Order.Zorn [Merged by Bors] - feat: port Order.Zorn Jan 1, 2023
@bors bors bot closed this Jan 1, 2023
@bors bors bot deleted the port/Order.Zorn branch January 1, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants