[Merged by Bors] - feat: port Algebra.Module.Pi #1283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrmacbeth
added
help-wanted
semorrison
added
the
merge-conflict
semorrison
removed
the
merge-conflict
|
One of the errors will be fixed after leanprover/lean4@70a6c06 makes it downstream to mathlib. Might as well wait and see if all of them are. |
hrmacbeth
added
blocked-by-core-PR
and removed
help-wanted
1 task
semorrison
added
blocked-by-other-PR
|
This PR/issue depends on:
|
hrmacbeth
added
awaiting-review
|
✌️ hrmacbeth can now approve this pull request. To approve and merge a pull request, simply reply with |
semorrison
added
delegated
and removed
awaiting-review
Co-authored-by: Johan Commelin <johan@commelin.net>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 7, 2023
One earlier failure was extensively discussed: - https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Performance.20issue.20with.20.60CompleteBooleanAlgebra.60/near/319019205 - https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/type.20class.20inference.20looping and is fixed as of leanprover/lean4@70a6c06, in mathlib as of the bump #1335. Another failure posted to Zulip and the Lean 4 repo - https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/type.20class.20inference.20failure.20in.20pi.20type - leanprover/lean4#2011 and is fixed as of leanprover/lean4@fedf235, in mathlib as of the bump #1397. There is one more mysterious `apply` failure, now worked around; we should track this down someday. - [x] depends on: #1397 Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
jcommelin
pushed a commit
that referenced
this pull request
Jan 23, 2023
One earlier failure was extensively discussed: - https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Performance.20issue.20with.20.60CompleteBooleanAlgebra.60/near/319019205 - https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/type.20class.20inference.20looping and is fixed as of leanprover/lean4@70a6c06, in mathlib as of the bump #1335. Another failure posted to Zulip and the Lean 4 repo - https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/type.20class.20inference.20failure.20in.20pi.20type - leanprover/lean4#2011 and is fixed as of leanprover/lean4@fedf235, in mathlib as of the bump #1397. There is one more mysterious `apply` failure, now worked around; we should track this down someday. - [x] depends on: #1397 Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One earlier failure was extensively discussed:
and is fixed as of leanprover/lean4@70a6c06, in mathlib as of the bump #1335.
Another failure posted to Zulip and the Lean 4 repo
and is fixed as of leanprover/lean4@fedf235, in mathlib as of the bump #1397.
There is one more mysterious
applyfailure, now worked around; we should track this down someday.