Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.SuccPred.IntervalSucc #1301

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Order.SuccPred.IntervalSucc #1301

wants to merge 7 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Jan 2, 2023 •
edited by bors bot

No description provided.

@mo271 mo271 added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Jan 2, 2023
dupuisf
dupuisf requested changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of lemma names need to be adjusted according to mathlib4's new naming scheme -- you can have a look at the porting wiki in the section "Naming convention" to see how this works.

Mathlib/Order/SuccPred/IntervalSucc.lean Outdated Show resolved Hide resolved
Mathlib/Order/SuccPred/IntervalSucc.lean Outdated Show resolved Hide resolved
Mathlib/Order/SuccPred/IntervalSucc.lean Outdated Show resolved Hide resolved
@dupuisf dupuisf added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 2, 2023
mo271 and others added 2 commits January 2, 2023 20:55
@mo271 @dupuisf
Apply suggestions from code review
d9673c5 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@mo271
naming, mainly in comments
77bdcd2
@mo271
Copy link
Collaborator Author

mo271 commented Jan 2, 2023

A lot of lemma names need to be adjusted according to mathlib4's new naming scheme -- you can have a look at the porting wiki in the section "Naming convention" to see how this works.

I corrected the bUnion thing and also the many names in the comments. Is there more, which I didn't see?

@mo271 mo271 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 2, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 2, 2023
@mo271 mo271 requested a review from dupuisf January 2, 2023 21:12
@mo271 mo271 removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 2, 2023
dupuisf
dupuisf reviewed Jan 2, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 2, 2023
bors bot pushed a commit that referenced this pull request Jan 2, 2023
@mo271
feat: port Order.SuccPred.IntervalSucc (#1301)
e3aa1bf 
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Jan 2, 2023

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@bors bors bot changed the title feat: port Order.SuccPred.IntervalSucc [Merged by Bors] - feat: port Order.SuccPred.IntervalSucc Jan 2, 2023
@bors bors bot closed this Jan 2, 2023
@bors bors bot deleted the port/order.succ_pred.interval_succ branch January 2, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf requested changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mo271 @dupuisf @semorrison