Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Nat.Bitwise #1404

Closed
wants to merge 16 commits into from
Closed

[Merged by Bors] - feat: port Data.Nat.Bitwise #1404

wants to merge 16 commits into from

Conversation

4e554c4c
Copy link
Collaborator

@4e554c4c 4e554c4c commented Jan 7, 2023 •
edited

@4e554c4c 4e554c4c added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 7, 2023
4e554c4c and others added 12 commits January 7, 2023 00:05
@4e554c4c 4e554c4c mentioned this pull request Jan 8, 2023
Closed
1 task
@4e554c4c 4e554c4c added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 8, 2023
@4e554c4c 4e554c4c added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jan 8, 2023
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Jan 8, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@ChrisHughes24
Copy link
Member

bors merge

@bors
Copy link

bors bot commented Jan 9, 2023

👎 Rejected by label

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 9, 2023
@ChrisHughes24 ChrisHughes24 removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jan 9, 2023
@ChrisHughes24
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Jan 9, 2023
@4e554c4c @semorrison @0art0
feat: port Data.Nat.Bitwise (#1404)
23f6bf2 
depends on
- [x] depends on: #1407
- [ ] depends on: #1415 otherwise simp cannot unify past a panic

would be nice:
- [ ] leanprover/lean4#2017 will simplify `bitwise_assoc_tac`

Co-authored-by: Calvin Lee <calvins.lee@utah.edu>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: ART0 <18333981+0Art0@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 9, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Nat.Bitwise [Merged by Bors] - feat: port Data.Nat.Bitwise Jan 9, 2023
@bors bors bot closed this Jan 9, 2023
@bors bors bot deleted the port/Data.Nat.Bitwise branch January 9, 2023 08:13
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@4e554c4c @semorrison
@0art0 @jcommelin
feat: port Data.Nat.Bitwise (#1404)
7fd021f 
depends on
- [x] depends on: #1407
- [ ] depends on: #1415 otherwise simp cannot unify past a panic

would be nice:
- [ ] leanprover/lean4#2017 will simplify `bitwise_assoc_tac`

Co-authored-by: Calvin Lee <calvins.lee@utah.edu>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: ART0 <18333981+0Art0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@4e554c4c @semorrison @ChrisHughes24 @0art0