Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: rename getI_zero_eq_head! to getI_zero_eq_headI #1415

Closed
wants to merge 1 commit into from

Conversation

4e554c4c
Copy link
Collaborator

@4e554c4c 4e554c4c commented Jan 7, 2023

it doesn't really make sense for List.getI 0 = List.head! when the latter panics.

@4e554c4c 4e554c4c added the awaiting-review The author would like community review of the PR label Jan 7, 2023
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 9, 2023
bors bot pushed a commit that referenced this pull request Jan 9, 2023
it doesn't really make sense for `List.getI 0 = List.head!` when the latter panics.

Co-authored-by: Calvin Lee <calvins.lee@utah.edu>
@bors
Copy link

bors bot commented Jan 9, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore: rename getI_zero_eq_head! to getI_zero_eq_headI [Merged by Bors] - chore: rename getI_zero_eq_head! to getI_zero_eq_headI Jan 9, 2023
@bors bors bot closed this Jan 9, 2023
@bors bors bot deleted the head!_to_headI branch January 9, 2023 08:08
bors bot pushed a commit that referenced this pull request Jan 9, 2023
depends on
- [x] depends on: #1407
- [ ] depends on: #1415 otherwise simp cannot unify past a panic

would be nice:
- [ ] leanprover/lean4#2017 will simplify `bitwise_assoc_tac`

Co-authored-by: Calvin Lee <calvins.lee@utah.edu>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: ART0 <18333981+0Art0@users.noreply.github.com>
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
it doesn't really make sense for `List.getI 0 = List.head!` when the latter panics.

Co-authored-by: Calvin Lee <calvins.lee@utah.edu>
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
depends on
- [x] depends on: #1407
- [ ] depends on: #1415 otherwise simp cannot unify past a panic

would be nice:
- [ ] leanprover/lean4#2017 will simplify `bitwise_assoc_tac`

Co-authored-by: Calvin Lee <calvins.lee@utah.edu>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: ART0 <18333981+0Art0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants