Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Revert "feat: port Mathlib.Data.Real.CauSeqCompletion (#1440)" #1468

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 10, 2023

This reverts commit 0a713e2.

The motivation is to allow leanprover-community/mathlib3#18122 to generate pre-port mathport output in the mathlib3port CI. Once that is done, I will unrevert this and merge in the changes it suggests.


Open in Gitpod

This is to some extent a workaround for not having a working mathport setup; but remembering to unrevert this is a lot easier than getting that set up.

This reverts commit 0a713e2.

The motivation is to allow leanprover-community/mathlib3#18122 to generate pre-port mathport output in the mathlib3port CI.
Once that is done, I will unrevert this and merge in the changes it suggests.
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 10, 2023
bors bot pushed a commit that referenced this pull request Jan 10, 2023
This reverts commit 0a713e2.

The motivation is to allow leanprover-community/mathlib3#18122 to generate pre-port mathport output in the mathlib3port CI. Once that is done, I will unrevert this and merge in the changes it suggests.
@bors
Copy link

bors bot commented Jan 10, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Revert "feat: port Mathlib.Data.Real.CauSeqCompletion (#1440)" [Merged by Bors] - Revert "feat: port Mathlib.Data.Real.CauSeqCompletion (#1440)" Jan 10, 2023
@bors bors bot closed this Jan 10, 2023
@bors bors bot deleted the eric-wieser/revert-1440 branch January 10, 2023 21:32
eric-wieser added a commit that referenced this pull request Jan 10, 2023
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
This reverts commit 0a713e2.

The motivation is to allow leanprover-community/mathlib3#18122 to generate pre-port mathport output in the mathlib3port CI. Once that is done, I will unrevert this and merge in the changes it suggests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants