Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Matrix.DMatrix #1605

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port Data.Matrix.DMatrix #1605

wants to merge 8 commits into from

Conversation

casavaca
Copy link
Collaborator

Open in Gitpod

@casavaca casavaca added help-wanted The author needs attention to resolve issues awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Jan 16, 2023
@casavaca
Copy link
Collaborator Author

casavaca commented Jan 16, 2023 •
edited

Update: Lint errors fixed.

Some Lint errors I don't know how to fix...

/- The `docBlame` linter reports:
DEFINITIONS ARE MISSING DOCUMENTATION STRINGS: -/
-- Mathlib.Data.Matrix.DMatrix
#check DMatrix.term_ᵀ /- definition missing documentation string -/

/- The `unusedArguments` linter reports:
UNUSED ARGUMENTS. -/
-- Mathlib.Data.Matrix.DMatrix
#check DMatrix.{u, u', v} /- argument 3 inst✝¹ : Fintype m, argument 4 inst✝ : Fintype n -/

@casavaca casavaca removed the help-wanted The author needs attention to resolve issues label Jan 16, 2023
dupuisf
dupuisf reviewed Jan 17, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few cosmetic things, otherwise LGTM!

bors d+

Mathlib/Data/Matrix/DMatrix.lean Outdated
Comment on lines 65 to 68
(M.map f).map g = M.map fun i j x => g (f x) :=
by
ext
simp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(M.map f).map g = M.map fun i j x => g (f x) :=
by
ext
simp
(M.map f).map g = M.map fun i j x => g (f x) := by ext; simp

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few other instances of this in the file as well.

Mathlib/Data/Matrix/DMatrix.lean Outdated
#align add_monoid_hom.map_dmatrix AddMonoidHom.mapDMatrix

@[simp]
theorem AddMonoidHom.map_DMatrix_apply [∀ i j, AddMonoid (α i j)] {β : m → n → Type w}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
theorem AddMonoidHom.map_DMatrix_apply [∀ i j, AddMonoid (α i j)] {β : m → n → Type w}
theorem AddMonoidHom.mapDMatrix_apply [∀ i j, AddMonoid (α i j)] {β : m → n → Type w}

@bors
Copy link

bors bot commented Jan 17, 2023

✌️ casavaca can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jan 17, 2023
@casavaca
combine short lines.
44219ae 
e.g. 'by' in a seperate line
@casavaca
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jan 17, 2023
@casavaca
feat: port Data.Matrix.DMatrix (#1605)
aae0a57
@bors
Copy link

bors bot commented Jan 17, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Matrix.DMatrix [Merged by Bors] - feat: port Data.Matrix.DMatrix Jan 17, 2023
@bors bors bot closed this Jan 17, 2023
@bors bors bot deleted the port/Data.Matrix.Dmatrix branch January 17, 2023 04:03
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@casavaca @jcommelin
feat: port Data.Matrix.DMatrix (#1605)
a16fe6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@casavaca @dupuisf @semorrison