[Merged by Bors] - feat: s ∩ t * s ∪ t ⊆ s * t
#1619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
the
mathlib3-pair
2 tasks
semorrison
added
the
awaiting-author
YaelDillies
force-pushed
the
inter_mul_union_subset
branch
from
f62b054
to
121e916
Compare
YaelDillies
added
awaiting-review
eric-wieser
reviewed
Mar 27, 2023
1 task
eric-wieser
reviewed
Mar 27, 2023
Mathlib/Data/Finset/Pointwise.lean
Outdated
Comment on lines
2041
to
2042
| @[to_additive (attr := simp)] | ||
| -- Porting note: should take priority over `Finite.toFinset_singleton` | ||
| @[to_additive (attr := simp high)] |
There was a problem hiding this comment.
As an explanation of what's going on here; lean reduces the definition of (1 : Set _) because it's hidden in an implicit argument. As a mwe:
import Mathlib.Data.Set.Pointwise.Finite
import Mathlib.Data.Finset.Pointwise
namespace Set
open scoped Pointwise
variable {α : Type _} [One α]
/-- A version of `toFinset` with an explicit `s` argument. -/
noncomputable def Finite.toFinset' (s : Set α) (hs : s.Finite) : Finset α := hs.toFinset
/-- A copy of `Finite.toFinset_singleton` -/
@[simp] lemma Finite.toFinset'_singleton (a : α) (hs : Set.Finite {a} := finite_singleton _) : hs.toFinset' _ = {a} :=
Finite.toFinset_singleton _
-- ok
@[simp] theorem Finite.toFinset'_one (h : (1 : Set α).Finite := finite_one) : h.toFinset' _ = 1 :=
Finite.toFinset_singleton _
-- rejected by linter
@[simp] theorem Finite.toFinset_one (h : (1 : Set α).Finite := finite_one) : h.toFinset = 1 :=
Finite.toFinset_singleton _
end Set
#lintI think this probably happened in Lean 3 too, but there the simp priority was automatically correct.
|
bors d+ Please merge once CI passes. |
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 27, 2023
Match leanprover-community/mathlib#17961 Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com> Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
s ∩ t * s ∪ t ⊆ s * ts ∩ t * s ∪ t ⊆ s * t
joelriou
pushed a commit
that referenced
this pull request
Mar 30, 2023
Match leanprover-community/mathlib#17961 Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com> Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match leanprover-community/mathlib#17961