Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Logic.Equiv.Fin #1745

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Logic.Equiv.Fin #1745

wants to merge 7 commits into from

Conversation

jcommelin
Copy link
Member

Open in Gitpod

@jcommelin jcommelin added the mathlib-port This is a port of a theory file from mathlib. label Jan 21, 2023
@urkud
Copy link
Member

urkud commented Jan 23, 2023

I'm going to merge #1741 into this branch, then fix errors.

@urkud urkud mentioned this pull request Jan 23, 2023
Closed
1 task
urkud and others added 4 commits January 23, 2023 18:53
@urkud @jcommelin
feat: port Logic.Equiv.Fin
b5418f6
@jcommelin
Initial file copy from mathport
13f87b3
@jcommelin
automated fixes
ffc4a8d 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@jcommelin
fixes
dc4d4aa
@jcommelin
Copy link
Member Author

Oops, I messed up the rebase. Will push a fix asap.

@jcommelin
Copy link
Member Author

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 23, 2023
bors bot pushed a commit that referenced this pull request Jan 23, 2023
@jcommelin @urkud
feat: port Logic.Equiv.Fin (#1745)
885e851 
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented Jan 23, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Logic.Equiv.Fin [Merged by Bors] - feat: port Logic.Equiv.Fin Jan 23, 2023
@bors bors bot closed this Jan 23, 2023
@bors bors bot deleted the port/Logic.Equiv.Fin branch January 23, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcommelin @urkud