Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Feat: port Data.Countable.Basic #1787

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Feat: port Data.Countable.Basic #1787

wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 23, 2023 •
edited by jcommelin

@urkud urkud mentioned this pull request Jan 23, 2023
Closed
1 task
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR to Mathlib and removed blocked-by-other-PR This PR depends on another PR to Mathlib labels Jan 23, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 23, 2023
urkud and others added 5 commits January 23, 2023 21:02
@urkud @jcommelin
feat: port Data.Countable.Basic
ef9bdb6
@urkud @jcommelin
Initial file copy from mathport
88e7a5c
@urkud @jcommelin
automated fixes
230e6fb 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@urkud @jcommelin
fixes
c926fbf
@jcommelin
auto: naming
10cafd1
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 23, 2023
jcommelin
jcommelin reviewed Jan 23, 2023
View reviewed changes
Mathlib/Data/Countable/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Countable/Basic.lean Outdated Show resolved Hide resolved
jcommelin
jcommelin approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added the ready-to-merge This PR has been sent to bors. label Jan 23, 2023
bors bot pushed a commit that referenced this pull request Jan 23, 2023
@urkud @jcommelin
Feat: port Data.Countable.Basic (#1787)
09d11b4 



Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jan 23, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Feat: port Data.Countable.Basic [Merged by Bors] - Feat: port Data.Countable.Basic Jan 23, 2023
@bors bors bot closed this Jan 23, 2023
@bors bors bot deleted the port/Data.Countable.Basic branch January 23, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @semorrison @jcommelin