Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.Basic #1826

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat: port Topology.Basic #1826

wants to merge 11 commits into from

Commits on Jan 25, 2023

  1. feat: port Topology.Basic

    @urkud
    urkud committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    9d19930 View commit details
    Browse the repository at this point in the history

  2. Initial file copy from mathport

    @urkud
    urkud committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    353f65f View commit details
    Browse the repository at this point in the history

  3. automated fixes 

    Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
    @urkud
    urkud committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    0ba17e4 View commit details
    Browse the repository at this point in the history

  4. Drop dependency on pfun

    @urkud
    urkud committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    5ddc5c4 View commit details
    Browse the repository at this point in the history

  5. Fix most of the file

    @urkud
    urkud committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    d93dc1c View commit details
    Browse the repository at this point in the history

  6. Fix lims

    @urkud
    urkud committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    0cbd7fc View commit details
    Browse the repository at this point in the history

  7. Fix comments (auto+manually)

    @urkud
    urkud committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    9722c39 View commit details
    Browse the repository at this point in the history

  8. drop a long line

    @urkud
    urkud committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    ba1dab9 View commit details
    Browse the repository at this point in the history

  9. Fix linter

    @urkud
    urkud committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    7f8aebc View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
    @urkud @dupuisf
    urkud and dupuisf committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    66677e2 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. limUnder

    @jcommelin
    jcommelin committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    c72fea5 View commit details
    Browse the repository at this point in the history