[Merged by Bors] - feat: port Topology.Basic #1826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
urkud
commented
Jan 25, 2023
urkud
commented
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
urkud
added
awaiting-review
dupuisf
reviewed
Jan 25, 2023
urkud
commented
Jan 25, 2023
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
jcommelin
reviewed
Jan 26, 2023
Mathlib/Topology/Basic.lean
Outdated
| noncomputable def lim [Nonempty α] (f : Filter β) (g : β → α) : α := | ||
| /-- If `f` is a filter in `β` and `g : β → α` is a function, then `lim_under f g` is a limit of `g` | ||
| at `f`, if it exists. -/ | ||
| noncomputable def lim_under [Nonempty α] (f : Filter β) (g : β → α) : α := |
There was a problem hiding this comment.
I think the naming convention would suggest camelCasing this:
Suggested change
| noncomputable def lim_under [Nonempty α] (f : Filter β) (g : β → α) : α := | |
| noncomputable def limUnder [Nonempty α] (f : Filter β) (g : β → α) : α := |
|
bors d+ |
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
Co-authored-by: Johan Commelin <johan@commelin.net>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Mar 27, 2023
These files have been primarily modified by backports and need little modification: * `topology.basic`: #1826 - modified with a porting note, which can now be removed * `data.real.cau_seq_completion`: #1469 - not a backport, but forgot to update the SHA * `order.filter.n_ary.basic`: #1967 - this PR forgot to update the SHA * `ring_theory.valuation.basic`: The change is a small golf that is now included in this PR Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.