Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.DirectSum.Ring #1968

Closed
wants to merge 19 commits into from
Closed

[Merged by Bors] - feat: port Algebra.DirectSum.Ring #1968

wants to merge 19 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Jan 31, 2023

Open in Gitpod

@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 31, 2023
@int-y1
Copy link
Collaborator Author

int-y1 commented Feb 1, 2023

Lean 4 keeps exceeding the max heartbeat limit. I'll stop working on this.

@nomeata
Copy link
Collaborator

nomeata commented Feb 3, 2023

I had a look, but couldn’t make progress. The very slow defEq checks probably mean that something is not working as it should. Even this small lemma is too slow

private theorem mul_to_mulHom (a b : ⨁ i, A i) : a * b = mulHom A a b := rfl

Needs more expert eyes than mine.

@nomeata
Copy link
Collaborator

nomeata commented Feb 3, 2023

Maybe related to #1260? Also mentions Rings and Timeouts.

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 17, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 4, 2023
@int-y1 int-y1 added the help-wanted The author needs attention to resolve issues label Apr 25, 2023
@mattrobball mattrobball removed the WIP Work in progress label May 16, 2023
@mattrobball mattrobball added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues please-adopt labels May 16, 2023
jcommelin
jcommelin reviewed May 17, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 17, 2023
bors bot pushed a commit that referenced this pull request May 17, 2023
@Ruben-VandeVelde @int-y1
@LukasMias @ocfnash @mattrobball
feat: port Algebra.DirectSum.Ring (#1968)
4e3c151 
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
Co-authored-by: Lukas Miaskiwskyi <lukas.mias@gmail.com>
Co-authored-by: Oliver Nash <github@olivernash.org>
Co-authored-by: Matthew Ballard <matt@mrb.email>
@bors
Copy link

bors bot commented May 17, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Algebra.DirectSum.Ring [Merged by Bors] - feat: port Algebra.DirectSum.Ring May 17, 2023
@bors bors bot closed this May 17, 2023
@bors bors bot deleted the port/Algebra.DirectSum.Ring branch May 17, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@int-y1 @nomeata @jcommelin @semorrison @mattrobball @Ruben-VandeVelde @LukasMias @ocfnash