Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.DirectSum.Ring #1968

Closed
wants to merge 19 commits into from
Closed

[Merged by Bors] - feat: port Algebra.DirectSum.Ring #1968

wants to merge 19 commits into from

Commits on Apr 7, 2023

  1. feat: port Algebra.DirectSum.Ring

    @Ruben-VandeVelde
    Ruben-VandeVelde committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    bf2513f View commit details
    Browse the repository at this point in the history

  2. Initial file copy from mathport

    @Ruben-VandeVelde
    Ruben-VandeVelde committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    717dc5e View commit details
    Browse the repository at this point in the history

  3. automated fixes 

    Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
    @Ruben-VandeVelde
    Ruben-VandeVelde committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    9627073 View commit details
    Browse the repository at this point in the history

  4. fix

    @int-y1 @Ruben-VandeVelde
    int-y1 authored and Ruben-VandeVelde committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    3ca3910 View commit details
    Browse the repository at this point in the history

  5. fix 2

    @int-y1 @Ruben-VandeVelde
    int-y1 authored and Ruben-VandeVelde committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    1f50aef View commit details
    Browse the repository at this point in the history

  6. fix G instance names

    @int-y1 @Ruben-VandeVelde
    int-y1 authored and Ruben-VandeVelde committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    c5c07ab View commit details
    Browse the repository at this point in the history

  7. fix 3

    @int-y1 @Ruben-VandeVelde
    int-y1 authored and Ruben-VandeVelde committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    553b6d1 View commit details
    Browse the repository at this point in the history

  8. better names

    @int-y1 @Ruben-VandeVelde
    int-y1 authored and Ruben-VandeVelde committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    32bcd2b View commit details
    Browse the repository at this point in the history

  9. fix one_mul

    @int-y1 @Ruben-VandeVelde
    int-y1 authored and Ruben-VandeVelde committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    790b20d View commit details
    Browse the repository at this point in the history

  10. add note for mul_one

    @int-y1 @Ruben-VandeVelde
    int-y1 authored and Ruben-VandeVelde committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    ed1f296 View commit details
    Browse the repository at this point in the history

  11. semiring still times out

    @int-y1 @Ruben-VandeVelde
    int-y1 authored and Ruben-VandeVelde committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    57b4df5 View commit details
    Browse the repository at this point in the history

  12. attempts at speedups

    @LukasMias @Ruben-VandeVelde
    LukasMias authored and Ruben-VandeVelde committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    bc4d86e View commit details
    Browse the repository at this point in the history

  13. small fixes & some mediocre docstrings

    @LukasMias @Ruben-VandeVelde
    LukasMias authored and Ruben-VandeVelde committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    7292ce6 View commit details
    Browse the repository at this point in the history

  14. Fix timeout in mul_comm by breaking out slow rfl proof into new l… 

    …emma `mulHom_apply`.

Also reinstating the original shape of the proof from Mathlib3
    @ocfnash @Ruben-VandeVelde
    ocfnash authored and Ruben-VandeVelde committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    e24969e View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Merge branch 'master' into port/Algebra.DirectSum.Ring

    @int-y1
    int-y1 committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    202d2ef View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Merge branch 'master' into port/Algebra.DirectSum.Ring

    @mattrobball
    mattrobball committed May 16, 2023
    Configuration menu
    Copy the full SHA
    33d7b69 View commit details
    Browse the repository at this point in the history

  2. fix all but two errors

    @mattrobball
    mattrobball committed May 16, 2023
    Configuration menu
    Copy the full SHA
    5bd3b7f View commit details
    Browse the repository at this point in the history

  3. fix last errors

    @mattrobball
    mattrobball committed May 16, 2023
    Configuration menu
    Copy the full SHA
    cc1a982 View commit details
    Browse the repository at this point in the history

  4. rename

    @mattrobball
    mattrobball committed May 16, 2023
    Configuration menu
    Copy the full SHA
    c1f513a View commit details
    Browse the repository at this point in the history