Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.DenseEmbedding #2003

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Topology.DenseEmbedding #2003

wants to merge 7 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 2, 2023

Open in Gitpod

@urkud
feat: port Topology.DenseEmbedding
5d319b0
@urkud
Initial file copy from mathport
89fd9b0
@urkud
automated fixes
499cd92 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@urkud
Partially fix
96e6662
@urkud
Fix
661de2a
@urkud
auto: naming
f3e9943
@urkud urkud force-pushed the port/Topology.DenseEmbedding branch from 23c833e to f3e9943 Compare February 2, 2023 07:35
@urkud urkud added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Feb 2, 2023
@jcommelin
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Feb 2, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 2, 2023
@jcommelin
Copy link
Member

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 2, 2023
bors bot pushed a commit that referenced this pull request Feb 2, 2023
@urkud
feat: port Topology.DenseEmbedding (#2003)
9102b25
@bors
Copy link

bors bot commented Feb 2, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.DenseEmbedding [Merged by Bors] - feat: port Topology.DenseEmbedding Feb 2, 2023
@bors bors bot closed this Feb 2, 2023
@bors bors bot deleted the port/Topology.DenseEmbedding branch February 2, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @jcommelin