Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.ContinuousFunction.Basic #2053

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - feat: port Topology.ContinuousFunction.Basic #2053

wants to merge 13 commits into from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented Feb 4, 2023

Open in Gitpod

@mcdoll
feat: port Topology.ContinuousFunction.Basic
3053151
@mcdoll
Initial file copy from mathport
afd1f15
@mcdoll
automated fixes
db8c58e 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@mcdoll mcdoll added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 4, 2023
@mcdoll mcdoll added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Feb 5, 2023
@mcdoll mcdoll mentioned this pull request Feb 6, 2023
Closed
1 task
dupuisf
dupuisf reviewed Feb 6, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

bors d+

Mathlib/Topology/ContinuousFunction/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Topology/ContinuousFunction/Basic.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Feb 6, 2023

✌️ mcdoll can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Feb 6, 2023
@mcdoll @dupuisf
Apply suggestions from code review
f744793 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@mcdoll
Copy link
Member Author

mcdoll commented Feb 6, 2023

bors merge

bors bot pushed a commit that referenced this pull request Feb 6, 2023
@mcdoll @Ruben-VandeVelde @kbuzzard
feat: port Topology.ContinuousFunction.Basic (#2053)
1f69478 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
@bors
Copy link

bors bot commented Feb 6, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.ContinuousFunction.Basic [Merged by Bors] - feat: port Topology.ContinuousFunction.Basic Feb 6, 2023
@bors bors bot closed this Feb 6, 2023
@bors bors bot deleted the port/Topology.ContinuousFunction.Basic branch February 6, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mcdoll @dupuisf @semorrison @Ruben-VandeVelde @kbuzzard