Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.Algebra.Star #2094

Closed
wants to merge 22 commits into from
Closed

[Merged by Bors] - feat: port Topology.Algebra.Star #2094

wants to merge 22 commits into from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented Feb 6, 2023 •
edited

mcdoll and others added 17 commits February 4, 2023 16:02
@mcdoll mcdoll added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 6, 2023
@mcdoll mcdoll changed the title feat: port Topology.ContinuousFunction.Basic feat: port Topology.Algebra.Star Feb 6, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 6, 2023
@mcdoll mcdoll added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Feb 6, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 6, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

dupuisf
dupuisf reviewed Feb 6, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 6, 2023
bors bot pushed a commit that referenced this pull request Feb 6, 2023
@mcdoll @Ruben-VandeVelde @kbuzzard
feat: port Topology.Algebra.Star (#2094)
d75bf7b 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
@bors
Copy link

bors bot commented Feb 6, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.Algebra.Star [Merged by Bors] - feat: port Topology.Algebra.Star Feb 6, 2023
@bors bors bot closed this Feb 6, 2023
@bors bors bot deleted the port/Topology.Algebra.Star branch February 6, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mcdoll @semorrison @dupuisf @Ruben-VandeVelde @kbuzzard