[Merged by Bors] - feat: tfae tactics
#2062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
thorimur
added
awaiting-review
jcommelin
reviewed
Feb 11, 2023
thorimur
commented
Feb 12, 2023
| failure | ||
| catch _ => | ||
| throwError "couldn't prove {P} → {P'}" | ||
| instantiateMVars t |
There was a problem hiding this comment.
I'd like to make sure that this instantiateMVars is in a good place, and check that it isn't needed further downstream.
semorrison
added
the
merge-conflict
semorrison
removed
the
merge-conflict
semorrison
added
the
merge-conflict
semorrison
removed
the
merge-conflict
|
@thorimur As far as I can tell, this is looking pretty good and stable. If you agree, let's just merge this. If there are small bugs, we can fix them later. bors d+ |
|
✌️ thorimur can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
We implement a basic version of #2061 to attain mathlib parity: * `tfae_have` followed by e.g. a tactic block, in parallel to mathlib `have` syntax (note: `tfae_have 1 → 2 := ...` is not supported yet, as it was not supported by the original `tfae_have` tactic, and would constitute new syntax) ``` example : TFAE [P, Q, R] := by tfae_have h : 1 → 2 { /- proof of P → Q -/ } tfae_have 2 → 3 { /- proof of Q → R -/ } ... ``` * `tfae_finish`, which looks through the local context and simply tries to prove each implication in a cycle via `solve_by_elim`
|
Pull request successfully merged into master. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implement a basic version of #2061 to attain mathlib parity:
tfae_havefollowed by e.g. a tactic block, in parallel to mathlibhavesyntax (note:tfae_have 1 → 2 := ...is not supported yet, as it was not supported by the originaltfae_havetactic, and would constitute new syntax)tfae_finish, which looks through the local context and simply tries to prove each implication in a cycle viasolve_by_elim