Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port SetTheory.Cardinal.Basic #2084

Closed
wants to merge 31 commits into from
Closed

[Merged by Bors] - feat: port SetTheory.Cardinal.Basic #2084

wants to merge 31 commits into from

Conversation

joneugster
Copy link
Collaborator

@joneugster joneugster commented Feb 5, 2023 •
edited
Loading

@joneugster joneugster added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 5, 2023
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR to Mathlib merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed blocked-by-other-PR This PR depends on another PR to Mathlib labels Feb 5, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 6, 2023
@joneugster joneugster added the help-wanted The author needs attention to resolve issues label Feb 6, 2023
@joneugster joneugster added awaiting-review and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Feb 9, 2023
This was referenced Feb 10, 2023
Closed
Closed
Closed
Closed
jcommelin
jcommelin reviewed Feb 11, 2023
View reviewed changes
Mathlib/SetTheory/Cardinal/Basic.lean Outdated Show resolved Hide resolved
Mathlib/SetTheory/Cardinal/Basic.lean Outdated Show resolved Hide resolved
Mathlib/SetTheory/Cardinal/Basic.lean Outdated Show resolved Hide resolved
Mathlib/SetTheory/Cardinal/Basic.lean Outdated Show resolved Hide resolved
Mathlib/SetTheory/Cardinal/Basic.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Feb 11, 2023
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 11, 2023
bors bot pushed a commit that referenced this pull request Feb 11, 2023
@joneugster @ChrisHughes24
@LukasMias @Ruben-VandeVelde
feat: port SetTheory.Cardinal.Basic (#2084)
f805dd1 
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Lukas Miaskiwskyi <lukas.mias@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bors
Copy link

bors bot commented Feb 11, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port SetTheory.Cardinal.Basic [Merged by Bors] - feat: port SetTheory.Cardinal.Basic Feb 11, 2023
@bors bors bot closed this Feb 11, 2023
@bors bors bot deleted the port/SetTheory.Cardinal.Basic branch February 11, 2023 10:25
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@joneugster @ChrisHughes24
@LukasMias @Ruben-VandeVelde @mo271
feat: port SetTheory.Cardinal.Basic (#2084)
9e85990 
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Lukas Miaskiwskyi <lukas.mias@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@joneugster @semorrison @jcommelin @ChrisHughes24 @LukasMias @Ruben-VandeVelde