Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat Port Data.Rat.Denumerable #2197

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat Port Data.Rat.Denumerable #2197

wants to merge 4 commits into from

Conversation

casavaca
Copy link
Collaborator

@casavaca casavaca added the mathlib-port This is a port of a theory file from mathlib. label Feb 11, 2023
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR to Mathlib and removed blocked-by-other-PR This PR depends on another PR to Mathlib labels Feb 11, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@casavaca
feat: port Data.Rat.Denumerable
098b0a8
@casavaca
Initial file copy from mathport
2cc9676
@casavaca
automated fixes
b1dad00 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@casavaca
Small changes
2a9b9a4
@casavaca casavaca added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Feb 11, 2023
jcommelin
jcommelin approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 11, 2023
bors bot pushed a commit that referenced this pull request Feb 11, 2023
@casavaca
feat Port Data.Rat.Denumerable (#2197)
b8109a5
@bors
Copy link

bors bot commented Feb 11, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat Port Data.Rat.Denumerable [Merged by Bors] - feat Port Data.Rat.Denumerable Feb 11, 2023
@bors bors bot closed this Feb 11, 2023
@bors bors bot deleted the port/Data.Rat.Denumerable branch February 11, 2023 19:30
mo271 pushed a commit that referenced this pull request Feb 12, 2023
@casavaca @mo271
feat Port Data.Rat.Denumerable (#2197)
3e242c6
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@casavaca @mo271
feat Port Data.Rat.Denumerable (#2197)
1f17eca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@casavaca @semorrison @jcommelin