Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.CompactOpen #2123

Closed
wants to merge 19 commits into from
Closed

[Merged by Bors] - feat: port Topology.CompactOpen #2123

wants to merge 19 commits into from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented Feb 7, 2023

Open in Gitpod

@mcdoll
feat: port Topology.CompactOpen
0574c0b
@mcdoll
Initial file copy from mathport
43c7d29
@mcdoll
automated fixes
e83be80 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@mcdoll
fixes
3f0c4e7
@mcdoll mcdoll added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 7, 2023
@mcdoll mcdoll added the help-wanted The author needs attention to resolve issues label Feb 7, 2023
@arienmalec arienmalec added awaiting-review and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Feb 8, 2023
dupuisf
dupuisf reviewed Feb 10, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

bors d+

Mathlib/Topology/CompactOpen.lean Outdated Show resolved Hide resolved
Mathlib/Topology/CompactOpen.lean Outdated Show resolved Hide resolved
Mathlib/Topology/CompactOpen.lean Outdated Show resolved Hide resolved
Mathlib/Topology/CompactOpen.lean Outdated Show resolved Hide resolved
Mathlib/Topology/CompactOpen.lean Outdated Show resolved Hide resolved
Mathlib/Topology/CompactOpen.lean Outdated Show resolved Hide resolved
Mathlib/Topology/CompactOpen.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Feb 10, 2023

✌️ mcdoll can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

mcdoll and others added 2 commits February 11, 2023 19:28
@mcdoll @dupuisf
Apply suggestions from code review
839d0c1 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@mcdoll
missing Infs
7580dc4
@mcdoll
Copy link
Member Author

mcdoll commented Feb 11, 2023

thanks Frederic, I forgot about aesop being a possible replacement for tidy.

bors merge

bors bot pushed a commit that referenced this pull request Feb 11, 2023
@mcdoll @arienmalec @adamtopaz
feat: port Topology.CompactOpen (#2123)
a908df6 
Co-authored-by: Arien Malec <arien.malec@gmail.com>
Co-authored-by: adamtopaz <github@adamtopaz.com>
@bors
Copy link

bors bot commented Feb 11, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.CompactOpen [Merged by Bors] - feat: port Topology.CompactOpen Feb 11, 2023
@bors bors bot closed this Feb 11, 2023
@bors bors bot deleted the port/Topology.CompactOpen branch February 11, 2023 09:31
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@mcdoll @arienmalec
@adamtopaz @mo271
feat: port Topology.CompactOpen (#2123)
de0033d 
Co-authored-by: Arien Malec <arien.malec@gmail.com>
Co-authored-by: adamtopaz <github@adamtopaz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcdoll @dupuisf @kim-em @arienmalec @adamtopaz