Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.Order.LowerTopology #2163

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port Topology.Order.LowerTopology #2163

wants to merge 9 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 8, 2023

Open in Gitpod

@urkud
feat: port Topology.Order.LowerTopology
f836205
@urkud
Initial file copy from mathport
005cbc7
@urkud
automated fixes
9936e60 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@urkud
Fix most errors
dcac35d
@urkud
semiauto: naming
2ceae41
@urkud @Vierkantor
Update Mathlib/Topology/Order/LowerTopology.lean
d5f4d2c 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@joneugster joneugster added the mathlib-port This is a port of a theory file from mathlib. label Feb 9, 2023
mcdoll
mcdoll reviewed Feb 10, 2023
View reviewed changes
Mathlib/Topology/Order/LowerTopology.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Order/LowerTopology.lean Outdated Show resolved Hide resolved
@mcdoll mcdoll added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Feb 10, 2023
@urkud urkud added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 10, 2023
jcommelin
jcommelin approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Feb 11, 2023
bors bot pushed a commit that referenced this pull request Feb 11, 2023
@urkud @jcommelin
feat: port Topology.Order.LowerTopology (#2163)
4be13d0 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Feb 11, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.Order.LowerTopology [Merged by Bors] - feat: port Topology.Order.LowerTopology Feb 11, 2023
@bors bors bot closed this Feb 11, 2023
@bors bors bot deleted the port/Topology.Order.LowerTopology branch February 11, 2023 09:31
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@urkud @jcommelin @mo271
feat: port Topology.Order.LowerTopology (#2163)
825236c 
Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor left review comments

@mcdoll mcdoll mcdoll left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@urkud @Vierkantor @jcommelin @mcdoll @semorrison @joneugster