Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port LinearAlgebra.Pi #2250

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat: port LinearAlgebra.Pi #2250

wants to merge 12 commits into from

Conversation

Komyyy
Copy link
Collaborator

@Komyyy Komyyy commented Feb 13, 2023

Open in Gitpod

@Komyyy
feat: port LinearAlgebra.Pi
61f23fb
@Komyyy
Initial file copy from mathport
8bb7192
@Komyyy
automated fixes
cdb547e 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@Komyyy Komyyy added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 13, 2023
@Komyyy Komyyy added awaiting-review and removed WIP Work in progress labels Feb 13, 2023
@Komyyy Komyyy added blocked-by-other-PR This PR depends on another PR to Mathlib and removed awaiting-review labels Feb 13, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR to Mathlib label Feb 13, 2023
@Komyyy Komyyy added WIP Work in progress awaiting-review and removed WIP Work in progress labels Feb 14, 2023
jcommelin
jcommelin approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Feb 14, 2023
bors bot pushed a commit that referenced this pull request Feb 14, 2023
@Komyyy
feat: port LinearAlgebra.Pi (#2250)
d6be0dc
@bors
Copy link

bors bot commented Feb 14, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port LinearAlgebra.Pi [Merged by Bors] - feat: port LinearAlgebra.Pi Feb 14, 2023
@bors bors bot closed this Feb 14, 2023
@bors bors bot deleted the port/LinearAlgebra.Pi branch February 14, 2023 06:44
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@Komyyy @mo271
feat: port LinearAlgebra.Pi (#2250)
13b1894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@ChrisHughes24 ChrisHughes24 ChrisHughes24 left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Komyyy @eric-wieser @jcommelin @ChrisHughes24 @semorrison