Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port LinearAlgebra.Finsupp #2277

Closed
wants to merge 28 commits into from
Closed

[Merged by Bors] - feat: port LinearAlgebra.Finsupp #2277

wants to merge 28 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin commented Feb 14, 2023 •
edited by github-actions bot

@jcommelin
feat: port LinearAlgebra.Finsupp
720ef19
@jcommelin
Initial file copy from mathport
674df28
@jcommelin
automated fixes
2bc67b8 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@jcommelin jcommelin added the mathlib-port This is a port of a theory file from mathlib. label Feb 14, 2023
@j-loreaux j-loreaux mentioned this pull request Feb 14, 2023
Closed
1 task
@Komyyy
Copy link
Collaborator

Komyyy commented Feb 17, 2023

I created the PR #2336 to port this file.

@Komyyy
Copy link
Collaborator

Komyyy commented Feb 17, 2023

I also created the PR #2347 to port this file.

@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 17, 2023
@Komyyy Komyyy added the WIP Work in progress label Feb 17, 2023
@Komyyy Komyyy removed the WIP Work in progress label Feb 18, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 20, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@Komyyy Komyyy added the awaiting-review The author would like community review of the PR label Feb 21, 2023
jcommelin
jcommelin commented Feb 21, 2023
View reviewed changes
Copy link
Member Author

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 21, 2023
bors bot pushed a commit that referenced this pull request Feb 21, 2023
@jcommelin @qawbecrdtey
@LukasMias @Komyyy
feat: port LinearAlgebra.Finsupp (#2277)
e74f747 
Co-authored-by: qawbecrdtey <qawbecrdtey@naver.com>
Co-authored-by: Lukas Miaskiwskyi <lukas.mias@gmail.com>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
@bors
Copy link

bors bot commented Feb 21, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port LinearAlgebra.Finsupp [Merged by Bors] - feat: port LinearAlgebra.Finsupp Feb 21, 2023
@bors bors bot closed this Feb 21, 2023
@bors bors bot deleted the port/LinearAlgebra.Finsupp branch February 21, 2023 08:15
bors bot pushed a commit that referenced this pull request Feb 21, 2023
@j-loreaux @jcommelin
feat: port RingTheory.Ideal.Basic (#2283)
3ce8f3f 
This only needs the dependency below in one place (otherwise `LinearAlgebra.Span` suffices as a replacement import). This file is done otherwise.

porting notes:
1. to appease the `simpNF` linter, I increased the priority of a few simp lemmas
2. The lean 4 issue 2074 appeared in (only one!) place in this file. I worked around it for now and left a note.

- [x] depends on: #2277 



Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jcommelin @Komyyy @semorrison @qawbecrdtey @LukasMias