-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor: fix LinearMap.coe_mk #2336
Conversation
This seems like it makes the lemma less general. I would suggest maybe changing the statement of theorem coe_mk {σ : R →+* S} (f : M →+ M₃) (h) :
((LinearMap.mk f h : M →ₛₗ[σ] M₃) : M →+ M₃) = f You could also add What do you think @eric-wieser ? |
We should have both the version with coe and with coe_fn; I'm a little surprised to hear that Lean3 only has the second of these. Maybe it has both and we forgot to port one of them |
I also add this.
|
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Thanks! 🎉 |
bors areyouasleep? bors merge |
Co-authored-by: Pol_tta <52843868+Komyyy@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded:
|
Co-authored-by: Pol_tta <52843868+Komyyy@users.noreply.github.com>
This PR fix
LinearMap.coe_mk
.to