Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor: semireducible Language #2307

Closed
wants to merge 1 commit into from

Conversation

Komyyy
Copy link
Collaborator

@Komyyy Komyyy commented Feb 16, 2023


This PR removes attribute [reducible] Language in Computability.Language to prevent to have new instances of Set (List α).

Open in Gitpod

@eric-wieser
Copy link
Member

eric-wieser commented Feb 16, 2023

I think probably forward-porting leanprover-community/mathlib3#18451 (assuming it gets merged) would be a better solution; but I guess this PR is still better than doing nothing.

@gebner
Copy link
Member

gebner commented Feb 16, 2023

Removing the attribute [reducible] gets us to the intended reducibility we had in Lean 3. This is how it should have been ported in the first place.

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Feb 16, 2023
bors bot pushed a commit that referenced this pull request Feb 16, 2023
@bors
Copy link

bors bot commented Feb 16, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor: semireducible Language [Merged by Bors] - refactor: semireducible Language Feb 16, 2023
@bors bors bot closed this Feb 16, 2023
@bors bors bot deleted the pol_tta/semireducible_Language branch February 16, 2023 23:56
mo271 pushed a commit that referenced this pull request Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants